Ledctl: add command to retrieve default controller #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktanska
force-pushed
the
ktanska/issue189
branch
2 times, most recently
from
7361edb
to
95ea477
Compare
ktanska
changed the title
ktanska
force-pushed
the
ktanska/issue189
branch
from
95ea477
to
7a81037
Compare
ktanska
force-pushed
the
ktanska/issue189
branch
4 times, most recently
from
99cad22
to
08be01b
Compare
mtkaczyk
previously approved these changes
Sep 10, 2024
bkucman
requested changes
Sep 10, 2024
bkucman
reviewed
Sep 10, 2024
ktanska
force-pushed
the
ktanska/issue189
branch
from
15d2b9d
to
3d2b53a
Compare
bkucman
requested changes
Sep 12, 2024
bkucman
previously approved these changes
Sep 18, 2024
mtkaczyk
requested changes
Sep 23, 2024
There was a problem hiding this comment.
Sorry, I just realized that we have to cover this in unit library tests:
https://github.com/intel/ledmon/blob/main/tests/lib_unit_test.c
ktanska
force-pushed
the
ktanska/issue189
branch
from
4f20013
to
b008f46
Compare
I see that lib_unit_test script uses only slot feature. I've retested it and problem did not appear. |
mtkaczyk
previously approved these changes
Sep 27, 2024
|
@peluse could you please look? Especially for wording, I'm not sure if "best" is the appropriate. The feature is addressing is a scenario where multiple controllers are detected for one disk (NPEM, VMD). |
Add new command to ledctl, which enables to print the best available controller for given device. Output from this can be helpful when user must specify controller in other ledctl commands. Fixes intel#189 Signed-off-by: Kinga Stefaniuk <kinga.stefaniuk@intel.com>
Add parameter tests for new command: --best-controller. Use new method to choose best controller for device. It is especially needed when VMD and NPEM are available on one platform. Skip IBPI test when drives are connected to better controller, than used to test. Test multipath drives only with best controller connected. Signed-off-by: Kinga Stefaniuk <kinga.stefaniuk@intel.com>
Add checking if controller used to find slot is not filtered out. It is needed to be checked for tests which are using drives instead of slots. Signed-off-by: Kinga Stefaniuk <kinga.stefaniuk@intel.com>
- Print "unsupported controller type" instead of "?" when ledctl is not able to find supported controller for device - Add help option for "--best-controller" command - Align tests to new help mode Signed-off-by: Kinga Stefaniuk <kinga.stefaniuk@intel.com>
Describe "--best-controller" option in ledctl manual. Signed-off-by: Kinga Stefaniuk <kinga.stefaniuk@intel.com>
Fix formatting error reported by YAPF. Signed-off-by: Kinga Stefaniuk <kinga.stefaniuk@intel.com>
- change message for device without best controller Signed-off-by: Kinga Stefaniuk <kinga.stefaniuk@intel.com>
Update ledctl.pod. Signed-off-by: Kinga Stefaniuk <kinga.stefaniuk@intel.com>
ktanska
force-pushed
the
ktanska/issue189
branch
from
b008f46
to
cd2be1f
Compare
ktanska
force-pushed
the
ktanska/issue189
branch
from
758dc64
to
8f39281
Compare
ktanska
changed the title
ktanska
force-pushed
the
ktanska/issue189
branch
from
8f39281
to
d1a821a
Compare
ktanska
force-pushed
the
ktanska/issue189
branch
from
d1a821a
to
57d6ab9
Compare
mtkaczyk
reviewed
Oct 11, 2024
ktanska
force-pushed
the
ktanska/issue189
branch
from
57d6ab9
to
39b6850
Compare
mku514k
previously approved these changes
Oct 11, 2024
mtkaczyk
reviewed
Oct 16, 2024
ktanska
force-pushed
the
ktanska/issue189
branch
from
39b6850
to
bc62780
Compare
Rename --best-controller to --default-controller. Signed-off-by: Kinga Stefaniuk <kinga.stefaniuk@intel.com>
mtkaczyk
approved these changes
Oct 16, 2024
mku514k
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new command to ledctl, which enables to print the default,
preferred available controller for given device. Output from this
can be helpful when user must specify controller in other
ledctl commands.
Add parameter tests for new command: --default-controller.
Use new method to choose default controller for device. It is especially
needed when VMD and NPEM are available on one platform. Skip IBPI test
when drive is connected to different default controller, than used to test.
Test multipath drives only with default controller connected.