Implement conversion from equirectangular projection to cubemap #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zongwave
reviewed
Aug 13, 2021
xcore/interface/stitcher.h
Outdated
| typedef std::vector<PointFloat2> PointMap; | ||
|
|
||
| public: | ||
| CubeMapModel (const uint32_t image_width, const uint32_t image_height); |
There was a problem hiding this comment.
do we need to declare a const type here?
There was a problem hiding this comment.
Removed const from this declaration
tests/test-surround-view.cpp
Outdated
| remap_topview_buf (outs[IdxStitch], outs[IdxTopView]); | ||
| write_out_image (outs[IdxTopView], frame_num); | ||
| if (out_config.save_cubemap) { | ||
| remap_topview_buf (outs[out_config.stitch_index], outs[out_config.cubemap_index]); |
There was a problem hiding this comment.
can we change this "remap_topview_buf" function name to "remap_buf"? since this function is used by topview & cubmap remap.
There was a problem hiding this comment.
Makes sense. Renamed this function. Thanks!
This function is now used also for cubemap generation, not only topview
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conversion is implemented by reusing geomap code, which is used at least for topview generation. New code calculates remap matrix and applies it with any supported geomap module: soft, gles or vulkan.
Usage example is provided in test-surround-view.
This pull request is part of Google Summer of Code project: https://summerofcode.withgoogle.com/projects/#4637812755791872