-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix compilation on 6.5 and shift op #157
base: main
Are you sure you want to change the base?
Conversation
reuse the patch from intel#151 and fix "shift exponent 32 is too large for 32-bit type 'int'" when loading the isgx module
This commit from ticapix@2f69bc4 fixes the issue #152, see #152 (comment) |
It is better to use in-kernel driver instead of this one since kernel 5.11. |
@andyzyb In the install guide, revision 1.1 from earlier this week 4/22/24, it says, "The Out-of-Tree Driver is recommended for use on platforms that do not support or are not configured for Flexible Launch Control." My machines don't have Flexible Launch Control. According to the documentation, the in-kernel driver only supports |
Then it can only use this driver if no FLC support. But I think Rust Fortanix EDP should also support other types of drivers as well. |
Thanks! Yes, this PR will fix the driver again for us. I've tested with my setup. Before the fix it was only working for Ubuntu 16.04 and 18.04. I think this is the only driver that exists for /dev/isgx though. |
@joshwyant I think this patch only works for the kernel which introduce vma wrapper functions. |
reuse the patch from #151 and fix "shift exponent 32 is too large for 32-bit type 'int'" when loading the isgx module