Update __config to make clangd happy #1019
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sgx-sdk uses _LIBCPP_COMPILER_GCC macro to modify the stl. However, when using clangd, the language sever defines __clang__ macro, so that if matches __clang__ first, the _LIBCPP_COMPILER_GCC will not be defined, thus causing clangd to report error.
haitaohuang
reviewed
Apr 4, 2024
| @@ -234,7 +234,7 @@ _LIBCPP_BEGIN_NAMESPACE_STD | |||
| // TODO: GCC 5 lies about its support for C++17 (it says it supports it but it | |||
| // really doesn't). That breaks variant, which uses some C++17 features. | |||
| // Remove this once we drop support for GCC 5. | |||
| #if _LIBCPP_STD_VER > 14 && !(defined(_LIBCPP_COMPILER_GCC) && _GNUC_VER_NEW < 6000) | |||
| #if _LIBCPP_STD_VER > 14 | |||
|
|
|||
There was a problem hiding this comment.
you commit message seems not match the changes. Can you state the problem to solve, then describe the changes accurately?
I don't see you update variant. You also removed condition for _LIBCPP_COMPILER_GCC. The reason for the changes is not clear to me.
also note the TODO comment. It seems we should only drop the condition if we don't support GCC5.
I'm not sure if we decided to do that. Maybe others have more ideas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sgx-sdk uses _LIBCPP_COMPILER_GCC macro to modify the stl. However, when using clangd, the language sever defines clang macro, so that if matches clang first, the _LIBCPP_COMPILER_GCC will not be defined, thus causing clangd to report error.