Fix escaping of regexes in sgx-asm-pp #1056
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running sgx-asm-pp.py on Python >= 3.12 generates many warnings: sgx-asm-pp.py:64: SyntaxWarning: invalid escape sequence '\s' sgx-asm-pp.py:85: SyntaxWarning: invalid escape sequence '\s' sgx-asm-pp.py:65: SyntaxWarning: invalid escape sequence '\s' sgx-asm-pp.py:86: SyntaxWarning: invalid escape sequence '\s' sgx-asm-pp.py:66: SyntaxWarning: invalid escape sequence '\s' This is a new python change: https://docs.python.org/3/whatsnew/3.12.html#other-language-changes "A backslash-character pair that is not a valid escape sequence now generates a SyntaxWarning, instead of DeprecationWarning. For example, re.compile("\d+\.\d+") now emits a SyntaxWarning ("\d" is an invalid escape sequence, use raw strings for regular expression: re.compile(r"\d+\.\d+")). In a future Python version, SyntaxError will eventually be raised, instead of SyntaxWarning." Given that python intends to turn this into an error in a future release, this should be proactively fixed now. Fortunately the regexes used by sgx-asm-pp don't appear to need to use any genuine backslash escapes, all the backslash usage is for regex characters, so the raw string conversion is simple. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
haitaohuang
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running sgx-asm-pp.py on Python >= 3.12 generates many warnings:
This is a new python change:
https://docs.python.org/3/whatsnew/3.12.html#other-language-changes
Given that python intends to turn this into an error in a future release, this should be proactively fixed now.
Fortunately the regexes used by sgx-asm-pp don't appear to need to use any genuine backslash escapes, all the backslash usage is for regex characters, so the raw string conversion is simple.