[SYCL] Update tests to use local_accessor #1063
Conversation
… into local_accessor
This PR creates the `local_accessor` class by aliasing the accessor class with `target::local`. The motivation behind this is that `target::local` has been deprecated in favour of `local_accessor` in SYCL2020. The approach of aliasing is taken as the spec states that local_access has the same semantics and restrictions as accessor with target::local. Related issue: #4713 llvm-test-suite: intel/llvm-test-suite#1063
|
@AidanBeltonS - Could you please resolve conflicts? |
… into local_accessor
|
Failures are likely due prebuilt intel/llvm being used from before the changes were merged. Should be resolved by rerunning the tests later. |
Would it be possible to rerun the tests now and see if they pass? |
|
Reran tests. Looks like there are some potentially related failures in pre-ci-linux. pre-ci-windows currently has a series of failures we are working on fixing so please disregard that for now. |
I have fixed the linux ci issues. Windows is still failing I think due to unrelated problems |
This PR updates tests that use `target::local` to local_accessor. In all cases the change should not functionally change the test. The goal is to move from the deprecated `target::local` accessor to `local_accessor`. Depends on: intel/llvm#6341
This PR updates tests that use `target::local` to local_accessor. In all cases the change should not functionally change the test. The goal is to move from the deprecated `target::local` accessor to `local_accessor`. Depends on: intel#6341
2 participants
This PR updates tests that use
target::localto local_accessor. In all cases the change should not functionally change the test. The goal is to move from the deprecatedtarget::localaccessor tolocal_accessor.Depends on: intel/llvm#6341