This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL][CUDA] Explicitly adding extension headers in tests. #1072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
|
/verify with intel/llvm#6386 |
1 similar comment
|
/verify with intel/llvm#6386 |
pvchupin
pushed a commit
to intel/llvm
that referenced
this pull request
Jul 1, 2022
…6386) C++17 usage of if constexpr etc was added to experimental/builtins.hpp as requested in #5964, but I did not remove this header from sycl.hpp since there were no failing tests and I didn't notice it was included in sycl.hpp. Apparently sycl.hpp should not include any usage of C++17. This may be related to some of the failing tests that appear only on the CI: intel/llvm-test-suite#975 (comment). Necessary changes to the tests are added here : intel/llvm-test-suite#1072 Signed-off-by: JackAKirk jack.kirk@codeplay.com
bader
pushed a commit
that referenced
this pull request
Jul 11, 2022
Reverts experimental/builtins.hpp includes added in #1072 and #1075. Requires: intel/llvm#6400
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
Explicitly including the extension headers since tests are complaining about missing extension functions/classes in : intel#975 (comment). Signed-off-by: JackAKirk jack.kirk@codeplay.com
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…m-test-suite#1072) Explicitly including the extension headers since tests are complaining about missing extension functions/classes in : intel#975 (comment). Signed-off-by: JackAKirk jack.kirk@codeplay.com
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…st-suite#1076) Reverts experimental/builtins.hpp includes added in intel/llvm-test-suite#1072 and intel/llvm-test-suite#1075. Requires: intel#6400
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly including the extension headers since tests are complaining about missing extension functions/classes in : #975 (comment).
Signed-off-by: JackAKirk jack.kirk@codeplay.com