Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL][CUDA][HIP] Fix device_num.cpp test #1081

Merged
merged 2 commits into from
Aug 5, 2022
Merged

Conversation

t4c1
Copy link

@t4c1 t4c1 commented Jul 11, 2022

Fixed device_num.cpp test for CUDA and HIP by adding entries for these two backends to the map from backend to its name.

@t4c1 t4c1 requested a review from a team as a code owner July 11, 2022 13:50
@t4c1 t4c1 requested a review from sergey-semenov July 11, 2022 13:50
@t4c1 t4c1 changed the title [SYCL][CUDA] Fix device_num.cpp test for CUDA and HIP [SYCL][CUDA][HIP] Fix device_num.cpp test Jul 12, 2022
@AerialMantis AerialMantis mentioned this pull request Aug 5, 2022
@pvchupin pvchupin merged commit b57e11f into intel:intel Aug 5, 2022
@bader
Copy link

bader commented Aug 8, 2022

@t4c1, the test failed in intel/llvm#6540 pre-commit.

https://github.com/intel/llvm/runs/7724054393?check_suite_focus=true
Any ideas what's wrong?

@steffenlarsen
Copy link

@t4c1, the test failed in intel/llvm#6540 pre-commit.

Failure has also been seen on intel/llvm#6539, so the failure is likely unrelated to the changes in intel/llvm#6540.

@t4c1
Copy link
Author

t4c1 commented Aug 8, 2022

The test works for me locally and the error on the CI is not exactly descriptive. But I can disable it again.

steffenlarsen pushed a commit that referenced this pull request Aug 9, 2022
Disables `device_num.cpp`, which was enabled recently in #1081 and despite working locally fails on CI.
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
Fixed device_num.cpp test for CUDA and HIP by adding entries for these two backends to the map from backend to its name.
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
Fixed device_num.cpp test for CUDA and HIP by adding entries for these two backends to the map from backend to its name.
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
Disables `device_num.cpp`, which was enabled recently in intel/llvm-test-suite#1081 and despite working locally fails on CI.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants