Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL][CUDA] Fix kernel bundle related tests #1093

Merged
merged 2 commits into from
Aug 5, 2022

Conversation

t4c1
Copy link

@t4c1 t4c1 commented Jul 13, 2022

Fixed kernel bundle related tests.

The following tests were just missing SYCL triple in the compile commands:
KernelAndProgram/kernel-bundle-merge-options.cpp
KernelAndProgram/kernel-bundle-merge-options-env.cpp
KernelAndProgram/multiple-kernel-linking.cpp

The following tests are checking that compilation errors are reported during runtime, but for CUDA and HIP these are actually reported at compile time. So these were marked as unsupported and a comment was added mentioning that:
KernelAndProgram/cache-build-result.cpp
KernelAndProgram/build-log.cpp
KernelAndProgram/undefined-symbol.cpp

@t4c1 t4c1 requested a review from a team as a code owner July 13, 2022 09:04
@t4c1 t4c1 requested a review from aelovikov-intel July 13, 2022 09:04
@aelovikov-intel
Copy link

but for CUDA and HIP these are actually reported at compile time

Is there an easy way to modify the code to delay it till runtime for those platforms as well?

@t4c1
Copy link
Author

t4c1 commented Jul 14, 2022

Delaying an error message would only simplify testing. For end users it does not really make sense. It is in general best if errors are reported as soon as they occur.

@aelovikov-intel
Copy link

I meant modifying the test, not the implementation.

@t4c1
Copy link
Author

t4c1 commented Jul 15, 2022

I don't see how we could change that in the test.

@AerialMantis AerialMantis mentioned this pull request Aug 5, 2022
@pvchupin pvchupin merged commit d5d594f into intel:intel Aug 5, 2022
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
Fixed kernel bundle related tests.

The following tests were just missing SYCL triple in the compile commands:
KernelAndProgram/kernel-bundle-merge-options.cpp
KernelAndProgram/kernel-bundle-merge-options-env.cpp
KernelAndProgram/multiple-kernel-linking.cpp

The following tests are checking that compilation errors are reported during runtime, but for CUDA and HIP these are actually reported at compile time. So these were marked as unsupported and a comment was added mentioning that:
KernelAndProgram/cache-build-result.cpp
KernelAndProgram/build-log.cpp
KernelAndProgram/undefined-symbol.cpp
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
)

Fixed kernel bundle related tests.

The following tests were just missing SYCL triple in the compile commands:
KernelAndProgram/kernel-bundle-merge-options.cpp
KernelAndProgram/kernel-bundle-merge-options-env.cpp
KernelAndProgram/multiple-kernel-linking.cpp

The following tests are checking that compilation errors are reported during runtime, but for CUDA and HIP these are actually reported at compile time. So these were marked as unsupported and a comment was added mentioning that:
KernelAndProgram/cache-build-result.cpp
KernelAndProgram/build-log.cpp
KernelAndProgram/undefined-symbol.cpp
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants