This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Add a LIT test for +=,*=,|=,^=,&= operations usable for reduce… #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-klochkov
added a commit
to v-klochkov/llvm
that referenced
this pull request
Feb 10, 2021
…educers The corresponding LIT test for this change-set is: intel/llvm-test-suite#140 Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
…r objects This test verifies this change-set: intel/llvm#3193 Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
v-klochkov
force-pushed
the
public_vklochkov_reduction_plus_eq
branch
from
ff01ace to
65f343e
Compare
This was referenced Feb 10, 2021
Pennycook
reviewed
Feb 10, 2021
Comment on lines
74
to
75
| Error += test<class B, XY>( | ||
| XY{}, [](auto A, auto B) { return XY(A.X + B.X, A.Y + B.Y); }); |
There was a problem hiding this comment.
I'm a little confused about this. SYCL 2020 says that operator+= should only be available if the combination function is plus. If we can support more than that it might be interesting to explore that in our extension, but in general I don't think users should expect this to work.
Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
…_reduction_plus_eq
Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
Pennycook
approved these changes
Feb 11, 2021
againull
pushed a commit
to intel/llvm
that referenced
this pull request
Feb 12, 2021
…educers (#3193) The corresponding LIT test for this change-set is: intel/llvm-test-suite#140 Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
zahiraam
pushed a commit
to zahiraam/llvm-1
that referenced
this pull request
Feb 16, 2021
…educers (intel#3193) The corresponding LIT test for this change-set is: intel/llvm-test-suite#140 Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
intel/llvm-test-suite#140) This test verifies this change-set: intel#3193 Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r objects
This test verifies this change-set: intel/llvm#3193
Signed-off-by: Vyacheslav N Klochkov vyacheslav.n.klochkov@intel.com