-
Notifications
You must be signed in to change notification settings - Fork 131
[SYCL] Add basic tests for non-uniform groups #1574
base: intel
Are you sure you want to change the base?
Conversation
@steffenlarsen - What's the new magic for running clang-format? I tried this, but it doesn't seem to be obeying the expected formatting... git diff -U0 --no-color HEAD^ | llvm/clang/tools/clang-format/clang-format-diff.py -p1 -i |
That is what I normally use, but sometimes different versions of clang-format may disagree on certain scenarios. You could try building a new version of clang-format and adding it to your PATH or just apply the suggested format by hand. |
Good idea. Building a new version of clang-format fixed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Converting this to draft to prevent it from being merged, same as intel/llvm#8202. |
Tests the ability to create an instance of each new group type, and the correctness of the core member functions. Signed-off-by: John Pennycook <john.pennycook@intel.com>
748675c
to
0dc4242
Compare
@steffenlarsen, @JackAKirk - These should be fixed, now, and aligned with the latest code over at intel/llvm#8202. |
Signed-off-by: John Pennycook <john.pennycook@intel.com>
@cperkinsintel, @steffenlarsen: I tried to make it so these won't run on CPU, but the failure logs in intel/llvm#8202 suggest it's still failing on the CPU. Have I got the UNSUPPORTED syntax wrong? |
Syntax looks right and since you're only using |
These tests are for a new feature. They have successfully run on the feature PR here: intel/llvm#8202 |
Tests for intel/llvm#8202.