This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Enable tests outside Unix environment (part 1) #475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbatashev
requested review from
a team,
bader,
kbobrovs,
romanovvlad,
smaslov-intel and
vladimirlaz
as code owners
vladimirlaz
previously approved these changes
Sep 30, 2021
s-kanaev
previously approved these changes
Sep 30, 2021
| @@ -1,5 +1,5 @@ | |||
| // RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out | |||
| // RUN: env SYCL_PARALLEL_FOR_RANGE_ROUNDING_TRACE=1 %GPU_RUN_PLACEHOLDER %t.out %GPU_CHECK_PLACEHOLDER | |||
| // RUN: %GPU_RUN_PLACEHOLDER env SYCL_PARALLEL_FOR_RANGE_ROUNDING_TRACE=1 %t.out %GPU_CHECK_PLACEHOLDER | |||
There was a problem hiding this comment.
My guess is that one can imply xxx_RUN_PLACE contains env (or other OS-dependent stuff) already. Should env be present on the RUN command in such a case, then?
Author
There was a problem hiding this comment.
env is LIT builtin command, as well as echo. And echo can't run env.
|
@alexbatashev, please, resolve merge conflicts. |
bader
suggested changes
Nov 23, 2021
bader
left a comment
bader
left a comment
There was a problem hiding this comment.
@alexbatashev, please, resolve new merge conflicts.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This part of the patch fixes some minor CMake misconfigurations and gets rid of
trueUnix utility. Other Unix utilities will be handled by Part 2.