This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Add gpu_aot_target_opts parameter #590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gpu_aot_target_opts LIT parameter and GPU_AOT_TARGET_OPTS CMake variable are introduced to allow customization of target device for AOT compilation on GPU.
vladimirlaz
requested review from
AGindinson,
AlexeySachkov,
Fznamznon,
bader,
dm-vodopyanov,
kbobrovs,
romanovvlad and
v-klochkov
as code owners
AGindinson
previously approved these changes
Nov 25, 2021
AGindinson
left a comment
AGindinson
left a comment
There was a problem hiding this comment.
LGTM personally. We should take note that -device * compilations take longer than -device <specified_platform> ones, but a) if there's no concern with llvm-test-suite CI time, it doesn't matter much at the moment; b) this is not something introduced by this patched.
bader
previously approved these changes
Nov 30, 2021
v-klochkov
previously approved these changes
Nov 30, 2021
vladimirlaz
dismissed stale reviews from v-klochkov, bader, and AGindinson
via
82a8403
v-klochkov
previously approved these changes
Nov 30, 2021
bader
approved these changes
Nov 30, 2021
v-klochkov
approved these changes
Nov 30, 2021
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
* [SYCL] Add gpu_aot_target_opts parameter The gpu_aot_target_opts LIT parameter and the GPU_AOT_TARGET_OPTS CMake variable is introduced to allow customization of the target device for AOT compilation on GPU. Co-authored-by: Alexey Bader <alexey.bader@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gpu_aot_target_opts LIT parameter and GPU_AOT_TARGET_OPTS CMake
variable are introduced to allow customization of the target device for
AOT compilation on GPU.