Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

Conversation

@smaslov-intel
Copy link

Test for barrier submission in intel/llvm#3045

Signed-off-by: Sergey V Maslov sergey.v.maslov@intel.com

bso-intel
bso-intel previously approved these changes Jan 19, 2021
Copy link

@bso-intel bso-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although this is a very corner case where no command is created before the barrier.

@vladimirlaz
Copy link

@smaslov-intel the test is passing without #3000 fix. Is it expected?

Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
@smaslov-intel
Copy link
Author

smaslov-intel commented Jan 21, 2021

@smaslov-intel the test is passing without #3000 fix. Is it expected?

Good catch. This was unexpected, and was caused by the fact host device was used.
I changed the test to use "default_selector". It should hang with the intel/llvm#3045 compiler fix.

bso-intel
bso-intel previously approved these changes Jan 22, 2021
Copy link

@bso-intel bso-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, it expectedly failed.
LGTM

@vladimirlaz
Copy link

The test will be submitted after retest with nightly containing product change.

@vladimirlaz
Copy link

vladimirlaz commented Jan 28, 2021

@smaslov-intel, could you please fix failure on CUDA?

@vladimirlaz vladimirlaz requested a review from bso-intel January 28, 2021 09:00
Copy link

@vladimirlaz vladimirlaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smaslov-intel, could you please fix failure on CUDA?

@smaslov-intel
Copy link
Author

smaslov-intel commented Feb 5, 2021

@smaslov-intel, could you please fix failure on CUDA?

@vladimirlaz : I cannot access the http://pre-commit.llvm.intel.com:8010/job/LLVM-Test-Suite-CI/job/LLVM-Test-Suite-CUDA/59/display/redirect (it says Network error). How do I restart the CUDA testing?

Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
@smaslov-intel
Copy link
Author

The CUDA failure is due to intel/llvm#3218.
I am disabling the new barrier test for CUDA in this PR.

Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
@vladimirlaz vladimirlaz merged commit f0587be into intel:intel Feb 15, 2021
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants