-
Notifications
You must be signed in to change notification settings - Fork 130
[SYCL] test for barrier submission: https://github.com/intel/llvm/pul… #98
Conversation
bso-intel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although this is a very corner case where no command is created before the barrier.
|
@smaslov-intel the test is passing without #3000 fix. Is it expected? |
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
Good catch. This was unexpected, and was caused by the fact host device was used. |
bso-intel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now, it expectedly failed.
LGTM
|
The test will be submitted after retest with nightly containing product change. |
|
@smaslov-intel, could you please fix failure on CUDA? |
vladimirlaz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smaslov-intel, could you please fix failure on CUDA?
@vladimirlaz : I cannot access the http://pre-commit.llvm.intel.com:8010/job/LLVM-Test-Suite-CI/job/LLVM-Test-Suite-CUDA/59/display/redirect (it says Network error). How do I restart the CUDA testing? |
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
|
The CUDA failure is due to intel/llvm#3218. |
Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
intel/llvm-test-suite#98) Signed-off-by: Sergey V Maslov <sergey.v.maslov@intel.com>
Test for barrier submission in intel/llvm#3045
Signed-off-by: Sergey V Maslov sergey.v.maslov@intel.com