Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvm-spirv/test/image.ll assertion after WW32 pulldown #10817

Closed
jsji opened this issue Aug 14, 2023 · 1 comment · Fixed by #15295
Closed

llvm-spirv/test/image.ll assertion after WW32 pulldown #10817

jsji opened this issue Aug 14, 2023 · 1 comment · Fixed by #15295
Labels
bug Something isn't working confirmed pdtracker Pulldown tracker for issues/reverts that needs follow up SPIR-V Issues related to SPIRV-LLVM-Translator

Comments

@jsji
Copy link
Contributor

jsji commented Aug 14, 2023

Describe the bug

In pulldown PR, we are seeing unexpected assertion in llvm-spirv/test/image.ll.
This needs further investigation and fix.

32bb25b#diff-b38b3325fb1d098b6805ee7a03755167137797af3cd8d621d698c4c5d13a11bf

To Reproduce

Merge #10783, built and run lit test.

Environment (please complete the following information):

  • OS: Linux

Additional context
@jsji jsji added the bug Something isn't working label Aug 14, 2023
@jsji jsji mentioned this issue Aug 14, 2023
Merged
@jsji jsji changed the title llvm-spirv/test/image.ll assertion after pulldown llvm-spirv/test/image.ll assertion after WW32 pulldown Sep 6, 2023
@jsji
Copy link
Contributor Author

jsji commented Sep 6, 2023

@intel/dpcpp-spirv-reviewers FYI. In case this was missed. Thanks.

@jsji jsji added the pdtracker Pulldown tracker for issues/reverts that needs follow up label Nov 16, 2023
@steffenlarsen steffenlarsen added SPIR-V Issues related to SPIRV-LLVM-Translator confirmed labels May 8, 2024
maarquitos14 added a commit to maarquitos14/llvm that referenced this issue Sep 5, 2024
@maarquitos14
Filter out illegal attributes to align with Khronos behaviour.
73c75ed 
Fixes intel#10817.

Signed-off-by: Marcos Maronas <marcos.maronas@intel.com>
maarquitos14 added a commit to maarquitos14/llvm that referenced this issue Sep 5, 2024
@maarquitos14
Filter out illegal attributes to align with Khronos behaviour.
a6fe5f3 
Fixes intel#10817.

Signed-off-by: Marcos Maronas <marcos.maronas@intel.com>
@maarquitos14 maarquitos14 mentioned this issue Sep 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working confirmed pdtracker Pulldown tracker for issues/reverts that needs follow up SPIR-V Issues related to SPIRV-LLVM-Translator
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SPIRV] Filter out illegal attributes to align with Khronos behaviour maarquitos14/llvm
2 participants
@jsji @steffenlarsen