Test SYCL :: OneapiDeviceSelector/illegal_input.cpp is failing on all configurations

[lbushi25]

Describe the bug

The test SYCL :: OneapiDeviceSelector/illegal_input.cpp is failing on all configurations.
Upon resolution, please remove XFAIL from test source.
The reproduction snippet is taken from the CI logs of this PR: #14354

To reproduce

/__w/llvm/llvm/toolchain/bin//clang++   -fsycl -fsycl-targets=spir64 /__w/llvm/llvm/llvm/sycl/test-e2e/OneapiDeviceSelector/Inputs/trivial.cpp -o /__w/llvm/llvm/build-e2e/OneapiDeviceSelector/Output/illegal_input.cpp.tmp.out

env ONEAPI_DEVICE_SELECTOR="macaroni:*"  /__w/llvm/llvm/build-e2e/OneapiDeviceSelector/Output/illegal_input.cpp.tmp.out

Environment

• OS: Agnostic
• Target device and vendor: Any
• DPC++ version: 54020cd (commit belongs to forked repo in the PR linked above)
• Dependencies version:

[opencl:gpu][opencl:0] Intel(R) OpenCL Graphics, Intel(R) Iris(R) Xe Graphics OpenCL 3.0 NEO  [24.13.29138.7]
[opencl:cpu][opencl:1] Intel(R) OpenCL, 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz OpenCL 3.0 (Build 0) [2024.17.3.0.09_160000]
[opencl:fpga][opencl:2] Intel(R) FPGA Emulation Platform for OpenCL(TM), Intel(R) FPGA Emulation Device OpenCL 1.2  [2024.17.3.0.09_160000]
[level_zero:gpu][level_zero:0] Intel(R) Level-Zero, Intel(R) Iris(R) Xe Graphics 12.0.0 [1.3.29138]
[native_cpu:cpu][native_cpu:0] SYCL_NATIVE_CPU, SYCL Native CPU 0.1 [0.0.0]

Platforms: 5
Platform [#1]:
    Version  : OpenCL 3.0 
    Name     : Intel(R) OpenCL Graphics
    Vendor   : Intel(R) Corporation
    Devices  : 1
        Device [#0]:
        Type              : gpu
        Version           : OpenCL 3.0 NEO 
        Name              : Intel(R) Iris(R) Xe Graphics
        Vendor            : Intel(R) Corporation
        Driver            : 24.13.29138.7
        UUID              : 13412873154100002000000
        Num SubDevices    : 0
        Num SubSubDevices : 0
        Aspects           : gpu fp16 online_compiler online_linker queue_profiling usm_device_allocations usm_host_allocations usm_shared_allocations atomic64 ext_intel_device_info_uuid ext_oneapi_srgb ext_intel_device_id ext_intel_legacy_image ext_intel_esimd ext_oneapi_ballot_group ext_oneapi_fixed_size_group ext_oneapi_opportunistic_group ext_oneapi_tangle_group ext_oneapi_private_alloca
        info::device::sub_group_sizes: 8 16 32
        Architecture: intel_gpu_tgllp
Platform [#2]:
    Version  : OpenCL 3.0 LINUX
    Name     : Intel(R) OpenCL
    Vendor   : Intel(R) Corporation
    Devices  : 1
        Device [#1]:
        Type              : cpu
        Version           : OpenCL 3.0 (Build 0)
        Name              : 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
        Vendor            : Intel(R) Corporation
        Driver            : 2024.17.3.0.09_160000
        Num SubDevices    : 0
        Num SubSubDevices : 0
        Aspects           : cpu fp16 fp64 online_compiler online_linker queue_profiling usm_device_allocations usm_host_allocations usm_shared_allocations usm_system_allocations usm_atomic_host_allocations usm_atomic_shared_allocations atomic64 ext_oneapi_srgb ext_oneapi_native_assert ext_intel_legacy_image ext_oneapi_ballot_group ext_oneapi_fixed_size_group ext_oneapi_opportunistic_group ext_oneapi_tangle_group ext_oneapi_private_alloca
        info::device::sub_group_sizes: 4 8 16 32 64
        Architecture: x86_64
Platform [#3]:
    Version  : OpenCL 1.2 Intel(R) FPGA SDK for OpenCL(TM), Version 20.3
    Name     : Intel(R) FPGA Emulation Platform for OpenCL(TM)
    Vendor   : Intel(R) Corporation
    Devices  : 1
        Device [#2]:
        Type              : fpga
        Version           : OpenCL 1.2 
        Name              : Intel(R) FPGA Emulation Device
        Vendor            : Intel(R) Corporation
        Driver            : 2024.17.3.0.09_160000
        Num SubDevices    : 0
        Num SubSubDevices : 0
        Aspects           : accelerator fp64 online_compiler online_linker queue_profiling usm_device_allocations usm_host_allocations usm_shared_allocations usm_atomic_host_allocations usm_atomic_shared_allocations ext_oneapi_srgb ext_oneapi_ballot_group ext_oneapi_fixed_size_group ext_oneapi_opportunistic_group ext_oneapi_tangle_group ext_intel_fpga_task_sequence ext_oneapi_private_alloca
        info::device::sub_group_sizes: 4 8 16 32 64
        Architecture: unknown
Platform [#4]:
    Version  : 1.3
    Name     : Intel(R) Level-Zero
    Vendor   : Intel(R) Corporation
    Devices  : 1
        Device [#0]:
        Type              : gpu
        Version           : 12.0.0
        Name              : Intel(R) Iris(R) Xe Graphics
        Vendor            : Intel(R) Corporation
        Driver            : 1.3.29138
        UUID              : 13412873154100002000000
        Num SubDevices    : 0
        Num SubSubDevices : 0
        Aspects           : gpu fp16 online_compiler online_linker queue_profiling usm_device_allocations usm_host_allocations usm_shared_allocations ext_intel_pci_address ext_intel_gpu_eu_count ext_intel_gpu_eu_simd_width ext_intel_gpu_slices ext_intel_gpu_subslices_per_slice ext_intel_gpu_eu_count_per_subslice atomic64 ext_intel_device_info_uuid ext_intel_gpu_hw_threads_per_eu ext_intel_device_id ext_intel_memory_clock_rate ext_intel_memory_bus_width ext_intel_legacy_image ext_oneapi_bindless_images ext_oneapi_bindless_images_shared_usm ext_oneapi_bindless_images_2d_usm ext_oneapi_mipmap ext_oneapi_mipmap_anisotropy ext_intel_esimd ext_oneapi_ballot_group ext_oneapi_fixed_size_group ext_oneapi_opportunistic_group ext_oneapi_tangle_group ext_oneapi_limited_graph ext_oneapi_private_alloca ext_oneapi_queue_profiling_tag
        info::device::sub_group_sizes: 8 16 32
        Architecture: intel_gpu_tgllp
Platform [#5]:
    Version  : 0.1
    Name     : SYCL_NATIVE_CPU
    Vendor   : tbd
    Devices  : 1
        Device [#0]:
        Type              : cpu
        Version           : 0.1
        Name              : SYCL Native CPU
        Vendor            : Intel(R) Corporation
        Driver            : 0.0.0
        Num SubDevices    : 0
        Num SubSubDevices : 0
        Aspects           : cpu fp16 fp64 queue_profiling usm_device_allocations usm_host_allocations usm_shared_allocations usm_system_allocations usm_atomic_host_allocations usm_atomic_shared_allocations atomic64
        info::device::sub_group_sizes: 1
        Architecture: unknown
default_selector()      : gpu, Intel(R) Level-Zero, Intel(R) Iris(R) Xe Graphics 12.0.0 [1.3.29138]
accelerator_selector()  : fpga, Intel(R) FPGA Emulation Platform for OpenCL(TM), Intel(R) FPGA Emulation Device OpenCL 1.2  [2024.17.3.0.09_160000]
cpu_selector()          : cpu, Intel(R) OpenCL, 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz OpenCL 3.0 (Build 0) [2024.17.3.0.09_160000]
gpu_selector()          : gpu, Intel(R) Level-Zero, Intel(R) Iris(R) Xe Graphics 12.0.0 [1.3.29138]
custom_selector(gpu)    : gpu, Intel(R) Level-Zero, Intel(R) Iris(R) Xe Graphics 12.0.0 [1.3.29138]
custom_selector(cpu)    : cpu, Intel(R) OpenCL, 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz OpenCL 3.0 (Build 0) [2024.17.3.0.09_160000]
custom_selector(acc)    : fpga, Intel(R) FPGA Emulation Platform for OpenCL(TM), Intel(R) FPGA Emulation Device OpenCL 1.2  [2024.17.3.0.09_160000]

Additional context

No response

[KseniyaTikhomirova]

@lbushi25 hi, could you please clarify why is it reported as issue? These tests is marked as XFAIL from the very beginning - they are intended to fail and it is valid result. 90b6aee#diff-791b6f50d8f942a9a1bb7f3e32359f7bcef6f52cf00bac0ae1cbaac95320ca90 So what exactly you expect to be fixed in this test?

[lbushi25]

@KseniyaTikhomirova Yes you're right, however I don't think an XFAIL is appropriate here. If I'm not mistaken, the not program in llvm-lit should be used to invert the exit code of the testing commands. @uditagarwal97 Could you have a look please as the original contributor of that test?
I'm closing this issue.

[lbushi25]

Issue has been closed because this is a negative test.

[KseniyaTikhomirova]

Yes you're right, however I don't think an XFAIL is appropriate here. If I'm not mistaken, the not program in llvm-lit should be used to invert the exit code of the testing commands. @uditagarwal97 Could you have a look please as the original contributor of that test? I'm closing this issue.

thanks for confirmation, I will do update by myself

[KseniyaTikhomirova]

#14865 to solve this