Skip to content

Two LLVM lit tests fail with BUILD_SHARED_LIBS flag set. #1478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bader opened this issue Apr 4, 2020 · 2 comments · Fixed by #3399
Closed

Two LLVM lit tests fail with BUILD_SHARED_LIBS flag set. #1478

bader opened this issue Apr 4, 2020 · 2 comments · Fixed by #3399
Assignees
@bader

Comments

@bader
Copy link
Contributor

bader commented Apr 4, 2020

Following tests are failing in post-commit job for the sycl branch.

Failing Tests (2):
    LLVM :: Other/cfg-printer-branch-weights.ll
    LLVM :: Other/cfg_deopt_unreach.ll

There are no obvious reasons why these tests might fail.
@bader bader mentioned this issue Apr 4, 2020
Merged
@AlexeySachkov
Copy link
Contributor

@bader, I can't reproduce those failures locally - does it make sense to try and revert your patch? Is it possible to check BUILD_SHARED_LIBS configuration in pre-commit somehow?

@bader
Copy link
Contributor Author

bader commented Dec 25, 2020

does it make sense to try and revert your patch?

If by "your patch" you mean ff0b066 then yes.

Is it possible to check BUILD_SHARED_LIBS configuration in pre-commit somehow?

You can add your pre-commit GitHub action workflow.

@bader bader self-assigned this Mar 23, 2021
bader added a commit to bader/llvm that referenced this issue Mar 23, 2021
@bader
Revert "Enable cfg-printer LLVM lit tests only if LLVM linked statica…
59ed227 
…lly (intel#1479)"

This reverts commit ff0b066.

Closes intel#1478.
@bader bader mentioned this issue Mar 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bader bader

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "Enable cfg-printer LLVM lit tests only if LLVM linked statica… bader/llvm
2 participants
@bader @AlexeySachkov