Skip to content

Visitor pattern for kernel/int-header gen needs to handle arrays. #1567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
erichkeane opened this issue Apr 22, 2020 · 2 comments
Closed

Visitor pattern for kernel/int-header gen needs to handle arrays. #1567

erichkeane opened this issue Apr 22, 2020 · 2 comments
Labels
Stale

Comments

@erichkeane
Copy link
Contributor

The new 'visitor' pattern (and as far as I can tell, the old version) doesn't iterate downward through arrays. The result is that accessors/etc in these are not split out.
@erichkeane erichkeane mentioned this issue Apr 22, 2020
Closed
@github-actions
Copy link
Contributor

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be automatically closed in 30 days.

@github-actions github-actions bot added the Stale label Feb 19, 2022
@github-actions
Copy link
Contributor

This issue was closed because it has been stalled for 30 days with no activity. Please, re-open if the issue still exists.

bb-sycl pushed a commit that referenced this issue Sep 15, 2022
@svenvh @dbudanov-cmplr
Restore getArgIndex in OCLTypeToSPIRV (#1567)
c34bf5a 
* Update for LLVM Optional API changes

Update for LLVM commit b5f8d42 ("[ADT] Deprecate
Optional::{hasValue,getValue} (NFC)", 2022-08-07).

This is a mechanical replacement of `hasValue` to `has_value` and
`getValue` to `value`.

* Restore argument tracing in OCLTypeToSPIRV

Commit 4a9c78ee ("Prepare SPIRVWriter for type conversion without
opaque pointers. (#1499)", 2022-06-20) removed `getArgIndex` in favor
of passing `Idx`, but this leads to incorrect adaptation of argument
types if sampler arguments are not in the same position between
different functions.

We might be able to drop `adaptArgumentsBySamplerUse` entirely, as we
don't represent samplers as i32 anymore; but for now just fix the
regression.

Fixes KhronosGroup/SPIRV-LLVM-Translator#1562

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@87f8a58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@erichkeane