Skip to content

[SYCL][Driver] Need to duplicate options to be passed to both host and device compilers. #1808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kbobrovs opened this issue Jun 3, 2020 · 1 comment
Closed

[SYCL][Driver] Need to duplicate options to be passed to both host and device compilers. #1808

kbobrovs opened this issue Jun 3, 2020 · 1 comment
Assignees
@AGindinson @mdtoguchi
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@kbobrovs
Copy link
Contributor

kbobrovs commented Jun 3, 2020

If it is needed to pass the same option from driver to both host and device compilers, then it must be added two-times - see clang/lib/Driver/ToolChains/Clang.cpp, for example:
4124:CmdArgs.push_back("-fsycl");
...
6150:CmdArgs.push_back("-fsycl");

This is quite error prone and inconvenient - should be automated: option placed in one place, driver does the duplication itself.
@kbobrovs kbobrovs added the good first issue Good for newcomers label Jun 3, 2020
@kbobrovs kbobrovs mentioned this issue Jun 3, 2020
Merged
@AlexeySachkov AlexeySachkov added the enhancement New feature or request label May 20, 2021
@mdtoguchi
Copy link
Contributor

There have been a few enhancements in this area which solve this issue:

bb-sycl pushed a commit that referenced this issue Feb 1, 2023
@svenvh @KornevNikita
Update for parseIR LLVM API change (#1808)
37951fa 
Update for llvm-project commit df1a74a ("[IR] Support importing
modules with invalid data layouts.", 2023-01-12).

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@79cd99d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AGindinson AGindinson

@mdtoguchi mdtoguchi

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@AlexeySachkov @kbobrovs @AGindinson @mdtoguchi