-
Notifications
You must be signed in to change notification settings - Fork 769
[UR][Graph] Strengthen in-order command-buffer property #18330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
EwanC
added a commit
to reble/llvm
that referenced
this issue
May 12, 2025
Actions issue intel#18330 to enhance the semantics of the UR command-buffer in-order property such that sync-point dependencies will always be ignored.
EwanC
added a commit
to reble/llvm
that referenced
this issue
May 13, 2025
Actions issue intel#18330 to enhance the semantics of the UR command-buffer in-order property such that sync-point dependencies will always be ignored.
EwanC
added a commit
to reble/llvm
that referenced
this issue
May 13, 2025
Actions issue intel#18330 to enhance the semantics of the UR command-buffer in-order property such that sync-point dependencies will always be ignored.
EwanC
added a commit
to reble/llvm
that referenced
this issue
May 13, 2025
Actions issue intel#18330 to enhance the semantics of the UR command-buffer in-order property such that sync-point dependencies will always be ignored.
EwanC
added a commit
to reble/llvm
that referenced
this issue
May 13, 2025
Actions issue intel#18330 to enhance the semantics of the UR command-buffer in-order property such that sync-point dependencies will always be ignored.
EwanC
added a commit
to reble/llvm
that referenced
this issue
May 14, 2025
Actions issue intel#18330 to enhance the semantics of the UR command-buffer in-order property such that sync-point dependencies will always be ignored.
EwanC
added a commit
to reble/llvm
that referenced
this issue
May 14, 2025
Actions issue intel#18330 to enhance the semantics of the UR command-buffer in-order property such that sync-point dependencies will always be ignored.
EwanC
added a commit
to reble/llvm
that referenced
this issue
May 14, 2025
Actions issue intel#18330 to enhance the semantics of the UR command-buffer in-order property such that sync-point dependencies will always be ignored.
sommerlukas
pushed a commit
that referenced
this issue
May 15, 2025
Closes issue #18330 to enhance the semantics of the UR command-buffer in-order property such that sync-point dependencies will always be ignored. Also fixes up an artifact in the UR command-buffer spec where it says that descriptors to the command-buffer creation API can be optional, when after #17058 they are mandatory.
Closed by #18444 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The in-order property when passed to on UR command-buffer creation is currently specified as
This is a hint that says an adapter may ignore the sync points a user passes, however valid UR usage is to still always pass sync-points with this property, as enforced with by the UR CTS tests.
The requirement to pass sync points even when an in-order UR command-buffer is confusing to users, who are likely to get this wrong and it work by accident (@EwanC has manually had to catch this in PR review a few times). It may also inefficient in that the SYCL RT needs to track the sync points of previous commands.
This task is to improve the UR command-buffer feature so that sync points are always ignored when an in-order command-buffer is created:
The text was updated successfully, but these errors were encountered: