Skip to content

id_queries_fit_int.cpp testing confusion #3335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AaronBallman opened this issue Mar 10, 2021 · 1 comment
Closed

id_queries_fit_int.cpp testing confusion #3335

AaronBallman opened this issue Mar 10, 2021 · 1 comment
Labels
confirmed

Comments

@AaronBallman
Copy link
Contributor

It looks like this test is supposed to check LLVM IR emitted by the host compiler. Right?

  1. Should we remove -fsycl as well? Is there a better way to get the result of host-side compilation?
  2. (not relevant to this PR) Should it be located in sycl/test/check_device_code/ directory, if it doesn't check device code at all?

Originally posted by @bader in #3259 (comment)
@AaronBallman AaronBallman mentioned this issue Mar 10, 2021
Merged
@github-actions github-actions bot added the Stale label Feb 18, 2022
@AlexeySachkov AlexeySachkov self-assigned this Mar 16, 2022
@intel intel deleted a comment from github-actions bot Mar 16, 2022
@AlexeySachkov AlexeySachkov removed their assignment Mar 16, 2022
@KseniyaTikhomirova
Copy link
Contributor

the test is already fixed by @s-kanaev in this PR #3751

  1. -fsycl is replaced with fsycl-device-only

  2. the test is still located in check_device_code since now it checks device compiler output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AaronBallman @AlexeySachkov @KseniyaTikhomirova