Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Incorrect aspect system allocator enumerator spelling #3962

Closed
pkeir opened this issue Jun 21, 2021 · 0 comments · Fixed by #4007
Closed

[SYCL] Incorrect aspect system allocator enumerator spelling #3962

pkeir opened this issue Jun 21, 2021 · 0 comments · Fixed by #4007
Assignees
@dm-vodopyanov
Labels
bug Something isn't working

Comments

@pkeir
Copy link
Contributor

pkeir commented Jun 21, 2021

The enumerator of the aspect enumeration which indicates "that the system allocator may be used instead of SYCL USM allocation mechanisms for usm::alloc::shared allocations" has a different spelling than in the SYCL 2020 specification.

In DPCPP's include/sycl/CL/sycl/aspects.hpp we find aspect::usm_system_allocator, whereas in the SYCL 2020 specification (p82. & p.84), this is spelled: aspect::usm_system_allocations.
@pkeir pkeir added the bug Something isn't working label Jun 21, 2021
@pkeir pkeir changed the title Incorrect aspect system allocator enumerator spelling [SYCL] Incorrect aspect system allocator enumerator spelling Jun 22, 2021
@dm-vodopyanov dm-vodopyanov self-assigned this Jun 28, 2021
@bader bader linked a pull request Jun 29, 2021 that will close this issue
[SYCL] Rename usm_system_allocator to usm_system_allocations #4007
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dm-vodopyanov dm-vodopyanov

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SYCL] Rename usm_system_allocator to usm_system_allocations dm-vodopyanov/llvm
2 participants
@pkeir @dm-vodopyanov