-
Notifications
You must be signed in to change notification settings - Fork 769
Do not diagnose unsupported __float128 type if it's not used in device code #943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Okay, we can start with simple disabling of diagnostic, like is was done for CUDA for _Float16 (see https://reviews.llvm.org/D57369). Then improve it once we implement deferred diagnostics for SYCL. |
No.
How difficult is to "implement deferred diagnostics for SYCL"? |
I'll take a look. I need some time to understand how it's supposed to work. |
Okay, I've learned something new about deferred diagnostics. Actually, we already have almost working implementation of this feature. But we still emit diagnostics in SemaSYCL from |
Fix and cleanups for deferred diagnostics is here #971 . Deferring of diagnostics about unsupported |
Submitted a change to disable diagnostic https://reviews.llvm.org/D74387 |
https://reviews.llvm.org/D74387 is submitted. |
Now LLORG clang emits the following diagnostics from standard headers:
and so on.
We disabled such diagnostics for device by the following change:
#181 (comment)
Experiments show that we don't emit any diagnostics if
__float128
is used in device code. IMO, that is not fully correct and this diagnostic should be delayed.The text was updated successfully, but these errors were encountered: