Skip to content

Conversation

@hchilama
Copy link
Contributor

@hchilama hchilama commented Jun 29, 2023

Clean up some logically dead code.

@hchilama hchilama requested a review from a team as a code owner June 29, 2023 00:27
@hchilama hchilama requested a review from mdtoguchi June 29, 2023 01:08
@hchilama hchilama changed the title [Driver][SYCL]Initializing an uninitialized variable and clean up some logically dead code [Driver][NFC]Initializing an uninitialized variable and clean up some logically dead code Jun 29, 2023
Copy link
Contributor

@mdtoguchi mdtoguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bader
Copy link
Contributor

bader commented Jun 29, 2023

LGTM

@mdtoguchi, please, approve via GitHub UI to unblock merging.

@mdtoguchi
Copy link
Contributor

LGTM

@mdtoguchi, please, approve via GitHub UI to unblock merging.

Thanks @bader. I didn't realize I was just adding a comment :)

@bader bader changed the title [Driver][NFC]Initializing an uninitialized variable and clean up some logically dead code [Driver][NFC] Initialize an uninitialized variable Jun 29, 2023
@bader bader merged commit e98280e into intel:sycl Jun 29, 2023
@hchilama hchilama deleted the quality_defects branch June 29, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants