Skip to content

[LIBCLC] Use amdgcn_fence builtin in mem_fence implementation #10133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
steffenlarsen merged 3 commits into from
Jul 18, 2023
Merged

[LIBCLC] Use amdgcn_fence builtin in mem_fence implementation #10133

steffenlarsen merged 3 commits into from
Jul 18, 2023

Conversation

@jchlanda
Copy link
Contributor

@jchlanda jchlanda commented Jun 29, 2023

No description provided.

@jchlanda jchlanda requested a review from a team as a code owner June 29, 2023 10:15
@jchlanda jchlanda requested a review from steffenlarsen June 29, 2023 10:15
@jchlanda jchlanda marked this pull request as draft June 29, 2023 10:15
@jchlanda jchlanda force-pushed the jakub/amd_mem_fence branch 3 times, most recently from 943d617 to 42046cb Compare June 29, 2023 11:58
@jchlanda jchlanda temporarily deployed to aws June 29, 2023 12:41 — with GitHub Actions Inactive
@jchlanda jchlanda temporarily deployed to aws June 29, 2023 15:06 — with GitHub Actions Inactive
@jchlanda jchlanda force-pushed the jakub/amd_mem_fence branch 2 times, most recently from 6117bfb to b30dac6 Compare July 5, 2023 07:10
@jchlanda jchlanda changed the title [LIBCLC] Use amdgcn_fence builtin in barrier implementation [LIBCLC] Use amdgcn_fence builtin in mem_fence implementation Jul 5, 2023
@jchlanda jchlanda marked this pull request as ready for review July 5, 2023 07:10
@jchlanda
Copy link
Contributor Author

jchlanda commented Jul 5, 2023

cc: @pgorlani

@jchlanda jchlanda temporarily deployed to aws July 5, 2023 07:25 — with GitHub Actions Inactive
@jchlanda jchlanda temporarily deployed to aws July 5, 2023 08:04 — with GitHub Actions Inactive
npmiller
npmiller reviewed Jul 5, 2023
View reviewed changes
@jchlanda jchlanda temporarily deployed to aws July 5, 2023 09:37 — with GitHub Actions Inactive
@jchlanda jchlanda temporarily deployed to aws July 5, 2023 10:16 — with GitHub Actions Inactive
@jchlanda jchlanda requested a review from npmiller July 17, 2023 10:03
@jchlanda
Copy link
Contributor Author

jchlanda commented Jul 17, 2023

@npmiller @steffenlarsen are you happy with this going in?

npmiller
npmiller reviewed Jul 17, 2023
View reviewed changes
npmiller
npmiller reviewed Jul 17, 2023
View reviewed changes
@jchlanda jchlanda requested a review from npmiller July 18, 2023 06:11
@jchlanda jchlanda force-pushed the jakub/amd_mem_fence branch from edfabcf to cd9a398 Compare July 18, 2023 07:56
@jchlanda jchlanda temporarily deployed to aws July 18, 2023 08:11 — with GitHub Actions Inactive
@jchlanda jchlanda temporarily deployed to aws July 18, 2023 08:52 — with GitHub Actions Inactive
@steffenlarsen steffenlarsen merged commit dcbcd74 into intel:sycl Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steffenlarsen steffenlarsen Awaiting requested review from steffenlarsen steffenlarsen is a code owner automatically assigned from intel/llvm-reviewers-cuda

1 more reviewer

@npmiller npmiller npmiller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jchlanda @npmiller @steffenlarsen