Skip to content

[SYCL] Remove deprecated sycl::group_local_memory #10223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aelovikov-intel merged 1 commit into from
Jul 10, 2023
Merged

[SYCL] Remove deprecated sycl::group_local_memory #10223

aelovikov-intel merged 1 commit into from
Jul 10, 2023

Conversation

@sergey-semenov
Copy link
Contributor

@sergey-semenov sergey-semenov commented Jul 5, 2023

No description provided.

@sergey-semenov sergey-semenov requested a review from a team as a code owner July 5, 2023 15:23
@jinz2014
Copy link
Contributor

jinz2014 commented Jul 5, 2023

Could you please suggest the new functions after the removal ?

@sergey-semenov
Copy link
Contributor Author

sergey-semenov commented Jul 5, 2023 •
edited
Loading

Could you please suggest the new functions after the removal ?

That would be sycl::ext::oneapi::group_local_memory. sycl::group_local_memory was originally added to the wrong namespace, that's why it was deprecated.

@sergey-semenov sergey-semenov temporarily deployed to aws July 5, 2023 16:46 — with GitHub Actions Inactive
@sergey-semenov sergey-semenov temporarily deployed to aws July 5, 2023 18:04 — with GitHub Actions Inactive
@sergey-semenov
Copy link
Contributor Author

sergey-semenov commented Jul 10, 2023

@cperkinsintel @intel/llvm-reviewers-runtime Could you please have a look?

@aelovikov-intel aelovikov-intel merged commit 1dc77a7 into intel:sycl Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

@cperkinsintel cperkinsintel Awaiting requested review from cperkinsintel cperkinsintel is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sergey-semenov @jinz2014 @aelovikov-intel