Skip to content

[SYCL][UR][L0] Use std::string instead of const char * in call map #10252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dm-vodopyanov merged 1 commit into from
Jul 10, 2023
Merged

[SYCL][UR][L0] Use std::string instead of const char * in call map #10252

dm-vodopyanov merged 1 commit into from
Jul 10, 2023

Conversation

@jandres742
Copy link
Contributor

@jandres742 jandres742 commented Jul 6, 2023

No description provided.

[SYCL][UR][L0] Use std::string instead of const char * in call map
ce6204a 
Signed-off-by: jaime.a.arteaga.molina <jarteaga@scsel-cfl-10.sc.intel.com>
@jandres742 jandres742 temporarily deployed to aws July 6, 2023 17:46 — with GitHub Actions Inactive
@bso-intel bso-intel self-requested a review July 6, 2023 18:35
bso-intel
bso-intel approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@bso-intel bso-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jandres742 jandres742 temporarily deployed to aws July 6, 2023 18:38 — with GitHub Actions Inactive
@jandres742
Copy link
Contributor Author

jandres742 commented Jul 6, 2023

failure is on opencl:cpu. Changes on this PR are L0-specific:

$ ":" "RUN: at line 4"
note: command had no output on stdout or stderr
$ "/__w/llvm/llvm/toolchain/bin/clang++" "-fsycl" "-fsycl-targets=spir64" "/__w/llvm/llvm/llvm/sycl/test-e2e/Regression/unoptimized_stream.cpp" "-O0" "-o" "/__w/llvm/llvm/build-e2e/Regression/Output/unoptimized_stream.cpp.tmp.out"
note: command had no output on stdout or stderr
$ ":" "RUN: at line 5"
note: command had no output on stdout or stderr
$ "env" "ONEAPI_DEVICE_SELECTOR=ext_oneapi_level_zero:gpu" "/__w/llvm/llvm/build-e2e/Regression/Output/unoptimized_stream.cpp.tmp.out"
# command output:
test
$ ":" "RUN: at line 5"
note: command had no output on stdout or stderr
$ "env" "ONEAPI_DEVICE_SELECTOR=opencl:gpu" "/__w/llvm/llvm/build-e2e/Regression/Output/unoptimized_stream.cpp.tmp.out"
# command output:
test
$ ":" "RUN: at line 5"
note: command had no output on stdout or stderr
$ "env" "ONEAPI_DEVICE_SELECTOR=opencl:cpu" "/__w/llvm/llvm/build-e2e/Regression/Output/unoptimized_stream.cpp.tmp.out"
# command output:
test
error: command failed with exit status: -9
error: command reached timeout: True

@jandres742 jandres742 marked this pull request as ready for review July 6, 2023 23:44
@jandres742 jandres742 requested a review from a team as a code owner July 6, 2023 23:44
@jandres742
Copy link
Contributor Author

jandres742 commented Jul 7, 2023

@intel/llvm-gatekeepers : please merge when possible. This is needed for some regressions found.

@dm-vodopyanov dm-vodopyanov merged commit b5c04e4 into intel:sycl Jul 10, 2023
veselypeta pushed a commit to veselypeta/llvm that referenced this pull request Sep 21, 2023
[SYCL][UR][L0] Use std::string instead of const char * in call map (i…
f23e307 
…ntel#10252)

Signed-off-by: jaime.a.arteaga.molina <jarteaga@scsel-cfl-10.sc.intel.com>
Co-authored-by: jaime.a.arteaga.molina <jarteaga@scsel-cfl-10.sc.intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@bso-intel bso-intel bso-intel approved these changes

@smaslov-intel smaslov-intel smaslov-intel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jandres742 @bso-intel @smaslov-intel @dm-vodopyanov