Skip to content

[SYCL][UR] Bump UR and implement adapter handles #10349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aelovikov-intel merged 17 commits into from
Jul 28, 2023
Merged

[SYCL][UR] Bump UR and implement adapter handles #10349

aelovikov-intel merged 17 commits into from
Jul 28, 2023

Conversation

@callumfare
Copy link
Contributor

@callumfare callumfare commented Jul 13, 2023 •
edited
Loading

Bump the Unified Runtime commit, and make adapter changes needed for the newly added adapter handles (see oneapi-src/unified-runtime#715 for details)

This fixes #10066 by providing an implementation of piPluginGetLastError in pi2ur.

@callumfare callumfare temporarily deployed to aws July 13, 2023 13:57 — with GitHub Actions Inactive
@callumfare callumfare mentioned this pull request Jul 13, 2023
Merged
@callumfare callumfare temporarily deployed to aws July 13, 2023 14:36 — with GitHub Actions Inactive
jandres742
jandres742 reviewed Jul 13, 2023
View reviewed changes
Copy link
Contributor

@jandres742 jandres742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes looking good

@callumfare callumfare temporarily deployed to aws July 14, 2023 12:47 — with GitHub Actions Inactive
@callumfare callumfare temporarily deployed to aws July 14, 2023 13:25 — with GitHub Actions Inactive
pbalcer
pbalcer reviewed Jul 17, 2023
View reviewed changes
@callumfare callumfare temporarily deployed to aws July 17, 2023 11:36 — with GitHub Actions Inactive
@callumfare callumfare temporarily deployed to aws July 17, 2023 13:19 — with GitHub Actions Inactive
@callumfare callumfare mentioned this pull request Jul 19, 2023
Closed
@callumfare callumfare marked this pull request as ready for review July 19, 2023 10:38
@callumfare callumfare requested review from a team as code owners July 19, 2023 10:38
@callumfare callumfare changed the title Draft: [SYCL][UR] Bump UR and implement adapter handles [SYCL][UR] Bump UR and implement adapter handles Jul 19, 2023
@callumfare callumfare temporarily deployed to aws July 19, 2023 10:48 — with GitHub Actions Inactive
@callumfare callumfare temporarily deployed to aws July 19, 2023 11:26 — with GitHub Actions Inactive
jandres742
jandres742 reviewed Jul 19, 2023
View reviewed changes
jandres742
jandres742 approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@jandres742 jandres742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment above.

jchlanda
jchlanda approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@jchlanda jchlanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CUDA/HIP 👍

@callumfare callumfare temporarily deployed to aws July 20, 2023 11:02 — with GitHub Actions Inactive
@callumfare callumfare temporarily deployed to aws July 20, 2023 11:46 — with GitHub Actions Inactive
This was referenced Jul 21, 2023
Closed
Closed
@callumfare callumfare requested a review from a team as a code owner July 27, 2023 10:30
@callumfare callumfare temporarily deployed to aws July 27, 2023 10:58 — with GitHub Actions Inactive
@callumfare callumfare temporarily deployed to aws July 27, 2023 11:47 — with GitHub Actions Inactive
@callumfare
Copy link
Contributor Author

callumfare commented Jul 27, 2023

The two CI failures appear to be unrelated to the changes:

ESIMD/api/functional/operators/operator_assignment_glb_mask.cpp
lsc/lsc_usm_block_load_u32_scalar_off.cpp

@jandres742 Do you know if these are expected?

@callumfare callumfare temporarily deployed to aws July 27, 2023 15:37 — with GitHub Actions Inactive
@callumfare callumfare temporarily deployed to aws July 27, 2023 16:17 — with GitHub Actions Inactive
@jandres742
Copy link
Contributor

jandres742 commented Jul 27, 2023

The two CI failures appear to be unrelated to the changes:

ESIMD/api/functional/operators/operator_assignment_glb_mask.cpp
lsc/lsc_usm_block_load_u32_scalar_off.cpp

@jandres742 Do you know if these are expected?

I tested locally your branch and test passed, and now I see all checks are clean, so it seems to be a glitch.

@callumfare callumfare temporarily deployed to aws July 28, 2023 09:40 — with GitHub Actions Inactive
@callumfare callumfare temporarily deployed to aws July 28, 2023 10:19 — with GitHub Actions Inactive
uwedolinsky
uwedolinsky approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@uwedolinsky uwedolinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NativeCPU 👍

@callumfare
Copy link
Contributor Author

callumfare commented Jul 28, 2023

@intel/llvm-gatekeepers This is ready to be merged

@aelovikov-intel aelovikov-intel merged commit 0717c40 into intel:sycl Jul 28, 2023
veselypeta pushed a commit to veselypeta/llvm that referenced this pull request Sep 21, 2023
@callumfare
[SYCL][UR] Bump UR and implement adapter handles (intel#10349)
d0298c2 
Bump the Unified Runtime commit, and make adapter changes needed for the
newly added adapter handles (see
oneapi-src/unified-runtime#715 for details)

This fixes intel#10066 by providing an implementation of
`piPluginGetLastError` in pi2ur.
fabiomestre pushed a commit to fabiomestre/llvm that referenced this pull request Sep 26, 2023
@callumfare
[SYCL][UR] Bump UR and implement adapter handles (intel#10349)
3a19c75 
Bump the Unified Runtime commit, and make adapter changes needed for the
newly added adapter handles (see
oneapi-src/unified-runtime#715 for details)

This fixes intel#10066 by providing an implementation of
`piPluginGetLastError` in pi2ur.
veselypeta pushed a commit to veselypeta/llvm that referenced this pull request Sep 28, 2023
@callumfare
[SYCL][UR] Bump UR and implement adapter handles (intel#10349)
3ca5fba 
Bump the Unified Runtime commit, and make adapter changes needed for the
newly added adapter handles (see
oneapi-src/unified-runtime#715 for details)

This fixes intel#10066 by providing an implementation of
`piPluginGetLastError` in pi2ur.
mdtoguchi pushed a commit to mdtoguchi/llvm that referenced this pull request Oct 18, 2023
@callumfare @mdtoguchi
[SYCL][UR] Bump UR and implement adapter handles (intel#10349)
233abe7 
Bump the Unified Runtime commit, and make adapter changes needed for the
newly added adapter handles (see
oneapi-src/unified-runtime#715 for details)

This fixes intel#10066 by providing an implementation of
`piPluginGetLastError` in pi2ur.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pbalcer pbalcer pbalcer approved these changes

@sergey-semenov sergey-semenov Awaiting requested review from sergey-semenov sergey-semenov was automatically assigned from intel/llvm-reviewers-cuda

+3 more reviewers

@jandres742 jandres742 jandres742 approved these changes

@jchlanda jchlanda jchlanda approved these changes

@uwedolinsky uwedolinsky uwedolinsky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[SYCL][UR] Fix piPluginGetLastError so native errors are not lost.

6 participants

@callumfare @jandres742 @jchlanda @pbalcer @uwedolinsky @aelovikov-intel