Skip to content

Conversation

@veselypeta
Copy link
Contributor

Currently if cuInit fails while getting platforms it returns UR_RESULT_SUCCESS. Instead we use UR_CHECK_ERROR to return the correct error code.

@veselypeta veselypeta requested a review from a team as a code owner July 13, 2023 14:51
@veselypeta veselypeta requested a review from steffenlarsen July 13, 2023 14:51
@veselypeta veselypeta temporarily deployed to aws July 13, 2023 15:06 — with GitHub Actions Inactive
@veselypeta veselypeta temporarily deployed to aws July 13, 2023 15:47 — with GitHub Actions Inactive
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@steffenlarsen steffenlarsen merged commit 45aace3 into intel:sycl Jul 13, 2023
@veselypeta veselypeta deleted the petr/report-error-on-cuinit branch August 29, 2023 13:16
fabiomestre pushed a commit to fabiomestre/llvm that referenced this pull request Sep 26, 2023
Currently if `cuInit` fails while getting platforms it returns
UR_RESULT_SUCCESS. Instead we use `UR_CHECK_ERROR` to return the correct
error code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants