[SYCL] Make image constructor notification pass reference optional #10419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some build configurations, the std::optional<image_target> used in sampledImageConstructorNotification and unsampledImageConstructorNotification may not get correctly passed to the library, causing a segfault when accessed in any way. This is fixed by making it a constant reference instead. Note: This changes only recently added symbols, so it is not a release-to-release ABI break. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
dm-vodopyanov
approved these changes
Jul 18, 2023
Contributor
Author
|
Precommit failures are known. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some build configurations, the std::optional<image_target> used in sampledImageConstructorNotification and
unsampledImageConstructorNotification may not get correctly passed to the library, causing a segfault when accessed in any way. This is fixed by making it a constant reference instead.
Note: This changes only recently added symbols, so it is not a release-to-release ABI break.