[SYCL][Bindless][3/4] Add experimental implementation of SYCL bindless images extension #10454

przemektmalon · 2023-07-18T15:12:57Z

This commit stands as the third commit of four to make code review easier, mostly covering the changes made to the user-facing SYCL API for the bindless images extension proposal.

Overview

The bindless images extension provides a new interface for allocating, creating, and accessing images in SYCL. Image memory allocation is seperated from image handle creation, and image handles can be passed to kernels without requesting access through accessors. This approach provides much more flexibility to the user, as well as enabling programs to implement features that were impossible to implement using standard SYCL images, such as a texture atlas. In addition to providing a new interface for images, this extension also provides initial experimental support for importing external memory into SYCL.

Following Split PRs

[4/4] Add tests

Authors

Co-authored-by: Isaac Ault isaac.ault@codeplay.com
Co-authored-by: Hugh Bird hugh.bird@codeplay.com
Co-authored-by: Duncan Brawley duncan.brawley@codeplay.com
Co-authored-by: Przemek Malon przemek.malon@codeplay.com
Co-authored-by: Chedy Najjar chedy.najjar@codeplay.com
Co-authored-by: Sean Stirling sean.stirling@codeplay.com
Co-authored-by: Peter Zuzek peter@codeplay.com

…s images extension This commit stands as the third commit of four to make code review easier, mostly covering the changes made to the user-facing SYCL API for the bindless images extension. The bindless images extension provides a new interface for allocating, creating, and accessing images in SYCL. Image memory allocation is seperated from image handle creation, and image handles can be passed to kernels without requesting access through accessors. This approach provides much more flexibility to the user, as well as enabling programs to implement features that were impossible to implement using standard SYCL images, such as a texture atlas. In addition to providing a new interface for images, this extension also provides initial experimental support for importing external memory into SYCL. Co-authored-by: Isaac Ault <isaac.ault@codeplay.com> Co-authored-by: Hugh Bird <hugh.bird@codeplay.com> Co-authored-by: Duncan Brawley <duncan.brawley@codeplay.com> Co-authored-by: Przemek Malon <przemek.malon@codeplay.com> Co-authored-by: Chedy Najjar <chedy.najjar@codeplay.com> Co-authored-by: Sean Stirling <sean.stirling@codeplay.com> Co-authored-by: Peter Zuzek <peter@codeplay.com> Implement revision 4 of the bindless images extension proposal: intel#9842

* Added missing `__SYCL_EXPORT` * Use fixed width `pi_uint64` instead of `unsigned long` * Added missing headers and forward declarations

przemektmalon · 2023-07-18T15:51:18Z

Please note that this PR depends on PR 2/4 to compile, hence CI won't pass until it that is merged.

EwanC

graph_impl.hpp changes LGTM. I tried this PR locally against our unmerged tests and it didn't regress anything.

jbrodman · 2023-07-19T23:29:37Z

Ping @intel/llvm-reviewers-runtime.

jbrodman · 2023-07-24T16:43:28Z

Where are we at on this? Outstanding test failures?

steffenlarsen · 2023-07-24T16:45:12Z

Where are we at on this? Outstanding test failures?

That, we need @intel/dpcpp-tools-reviewers approval, and there seem to be merge conflicts that need to be resolved.

AlexeySachkov

SYCLLowerIR changes LGTM. @maarquitos14: FYI

maarquitos14

Changes related to device traits and device config file look good to me.

Seanst98 · 2023-07-25T13:55:44Z

The fourth PR has been posted and can be reviewed alongside this PR.

dm-vodopyanov · 2023-07-25T17:18:19Z

Build failure in post-commit:
https://github.com/intel/llvm/actions/runs/5659303006/job/15332561363
https://github.com/intel/llvm/actions/runs/5659303006/job/15332556220

@przemektmalon could you please fix ASAP?

Fix compiler error/warnings related to unused variables/parameters Post-commit fix for PR: intel#10454

Seanst98 · 2023-07-26T11:29:44Z

Build failure in post-commit: https://github.com/intel/llvm/actions/runs/5659303006/job/15332561363 https://github.com/intel/llvm/actions/runs/5659303006/job/15332556220

@przemektmalon could you please fix ASAP?

Created #10574 to address this

Fix compiler error/warnings related to unused variables/parameters Post-commit fix for PR: #10454 Co-authored-by: Przemek Malon <przemek.malon@codeplay.com>

…CL bindless images extension (#10500) # Experimental Implementation of SYCL Bindless Images Extension This commit stands as the fourth, and final, commit of four to make code review easier, covering the additional tests for bindless images to the e2e test suite. Implementing [revision 4 of the bindless images extension proposal](#9842). This will not compile or run until [PR3](#10454) has been merged. However, it can be reviewed simultaneously with PR3. ## Overview The bindless images extension provides a new interface for allocating, creating, and accessing images in SYCL. Image memory allocation is seperated from image handle creation, and image handles can be passed to kernels without requesting access through accessors. This approach provides much more flexibility to the user, as well as enabling programs to implement features that were impossible to implement using standard SYCL images, such as a texture atlas. In addition to providing a new interface for images, this extension also provides initial experimental support for importing external memory into SYCL. ## Previous PRs * [1/4] [libclc](#9808) * [2/4] [PI/UR](#10112) * [3/4] [SYCL API](#10454) * [4/4] Tests <--- This one ## Authors Co-authored-by: Isaac Ault isaac.ault@codeplay.com Co-authored-by: Hugh Bird hugh.bird@codeplay.com Co-authored-by: Duncan Brawley duncan.brawley@codeplay.com Co-authored-by: Przemek Malon przemek.malon@codeplay.com Co-authored-by: Chedy Najjar chedy.najjar@codeplay.com Co-authored-by: Sean Stirling sean.stirling@codeplay.com Co-authored-by: Peter Zuzek peter@codeplay.com Co-authored-by: SYCL Unbound Team <sycl.unbound@codeplay.com>

…s images extension (intel#10454) This commit stands as the third commit of four to make code review easier, mostly covering the changes made to the user-facing SYCL API for the [bindless images extension proposal](intel#9842). ### Overview The bindless images extension provides a new interface for allocating, creating, and accessing images in SYCL. Image memory allocation is seperated from image handle creation, and image handles can be passed to kernels without requesting access through accessors. This approach provides much more flexibility to the user, as well as enabling programs to implement features that were impossible to implement using standard SYCL images, such as a texture atlas. In addition to providing a new interface for images, this extension also provides initial experimental support for importing external memory into SYCL. ### Following Split PRs - [4/4] Add tests ### Authors Co-authored-by: Isaac Ault <isaac.ault@codeplay.com> Co-authored-by: Hugh Bird <hugh.bird@codeplay.com> Co-authored-by: Duncan Brawley <duncan.brawley@codeplay.com> Co-authored-by: Przemek Malon <przemek.malon@codeplay.com> Co-authored-by: Chedy Najjar <chedy.najjar@codeplay.com> Co-authored-by: Sean Stirling <sean.stirling@codeplay.com> Co-authored-by: Peter Zuzek <peter@codeplay.com>

Fix compiler error/warnings related to unused variables/parameters Post-commit fix for PR: intel#10454 Co-authored-by: Przemek Malon <przemek.malon@codeplay.com>

…CL bindless images extension (intel#10500) # Experimental Implementation of SYCL Bindless Images Extension This commit stands as the fourth, and final, commit of four to make code review easier, covering the additional tests for bindless images to the e2e test suite. Implementing [revision 4 of the bindless images extension proposal](intel#9842). This will not compile or run until [PR3](intel#10454) has been merged. However, it can be reviewed simultaneously with PR3. ## Overview The bindless images extension provides a new interface for allocating, creating, and accessing images in SYCL. Image memory allocation is seperated from image handle creation, and image handles can be passed to kernels without requesting access through accessors. This approach provides much more flexibility to the user, as well as enabling programs to implement features that were impossible to implement using standard SYCL images, such as a texture atlas. In addition to providing a new interface for images, this extension also provides initial experimental support for importing external memory into SYCL. ## Previous PRs * [1/4] [libclc](intel#9808) * [2/4] [PI/UR](intel#10112) * [3/4] [SYCL API](intel#10454) * [4/4] Tests <--- This one ## Authors Co-authored-by: Isaac Ault isaac.ault@codeplay.com Co-authored-by: Hugh Bird hugh.bird@codeplay.com Co-authored-by: Duncan Brawley duncan.brawley@codeplay.com Co-authored-by: Przemek Malon przemek.malon@codeplay.com Co-authored-by: Chedy Najjar chedy.najjar@codeplay.com Co-authored-by: Sean Stirling sean.stirling@codeplay.com Co-authored-by: Peter Zuzek peter@codeplay.com Co-authored-by: SYCL Unbound Team <sycl.unbound@codeplay.com>

przemektmalon requested a review from a team as a code owner July 18, 2023 15:12

przemektmalon requested a review from againull July 18, 2023 15:12

SYCL Unbound Team and others added 3 commits July 18, 2023 16:21

[SYCL][Bindless] Compile on Windows

726bf42

* Added missing `__SYCL_EXPORT` * Use fixed width `pi_uint64` instead of `unsigned long` * Added missing headers and forward declarations

Apply clang-format

965eafa

przemektmalon force-pushed the codeplay/bindless_images_sycl branch from bbe79a5 to 965eafa Compare July 18, 2023 15:32

przemektmalon temporarily deployed to aws July 18, 2023 15:42 — with GitHub Actions Inactive

ProGTX added 3 commits July 18, 2023 17:12

Merge branch 'sycl' into codeplay/bindless_images_sycl

49ed6fa

Added missing aspects

6b10323

Merge branch 'sycl' into codeplay/bindless_images_sycl

55d260e

ProGTX requested a review from a team as a code owner July 18, 2023 17:24

ProGTX temporarily deployed to aws July 18, 2023 17:44 — with GitHub Actions Inactive

ProGTX temporarily deployed to aws July 18, 2023 18:36 — with GitHub Actions Inactive

ProGTX added 2 commits July 19, 2023 08:44

Device trait alignment with the proposal

2bf2643

Added Linux ABI symbols

b8e1aa7

ProGTX requested a review from a team as a code owner July 19, 2023 07:46

ProGTX temporarily deployed to aws July 19, 2023 08:08 — with GitHub Actions Inactive

ProGTX added 2 commits July 19, 2023 09:34

Merge branch 'sycl' into codeplay/bindless_images_sycl

9068a23

Add Windows ABI symbols

d11349e

ProGTX temporarily deployed to aws July 19, 2023 09:01 — with GitHub Actions Inactive

ProGTX temporarily deployed to aws July 19, 2023 09:41 — with GitHub Actions Inactive

EwanC approved these changes Jul 19, 2023

View reviewed changes

ProGTX added 2 commits July 19, 2023 18:15

Merge branch 'sycl' into codeplay/bindless_images_sycl

05f35f1

Update Windows ABI

167c50c

ProGTX temporarily deployed to aws July 19, 2023 17:51 — with GitHub Actions Inactive

Merge branch 'sycl' into codeplay/bindless_images_sycl

c8fbc65

ProGTX temporarily deployed to aws July 19, 2023 18:23 — with GitHub Actions Inactive

ProGTX temporarily deployed to aws July 19, 2023 19:27 — with GitHub Actions Inactive

Przemek Malon added 2 commits July 21, 2023 13:50

Address feedback

a83e54e

Regenerate linux symbols

21f67c0

steffenlarsen approved these changes Jul 21, 2023

View reviewed changes

przemektmalon temporarily deployed to aws July 21, 2023 13:37 — with GitHub Actions Inactive

przemektmalon temporarily deployed to aws July 21, 2023 14:16 — with GitHub Actions Inactive

Regenerate Windows symbols

da0a9f5

AlexeySachkov approved these changes Jul 25, 2023

View reviewed changes

przemektmalon temporarily deployed to aws July 25, 2023 08:54 — with GitHub Actions Inactive

przemektmalon temporarily deployed to aws July 25, 2023 09:33 — with GitHub Actions Inactive

Merge branch 'sycl' into codeplay/bindless_images_sycl

e81d7d2

maarquitos14 approved these changes Jul 25, 2023

View reviewed changes

przemektmalon temporarily deployed to aws July 25, 2023 10:24 — with GitHub Actions Inactive

przemektmalon temporarily deployed to aws July 25, 2023 11:03 — with GitHub Actions Inactive

Merge branch 'sycl' into codeplay/bindless_images_sycl

96d1287

przemektmalon temporarily deployed to aws July 25, 2023 14:34 — with GitHub Actions Inactive

przemektmalon temporarily deployed to aws July 25, 2023 15:13 — with GitHub Actions Inactive

steffenlarsen merged commit b1aab04 into intel:sycl Jul 25, 2023

Seanst98 added a commit to codeplaysoftware/intel-llvm-mirror that referenced this pull request Jul 26, 2023

[SYCL][Bindless] Fix compiler Werrors

4e3bd94

Fix compiler error/warnings related to unused variables/parameters Post-commit fix for PR: intel#10454

Seanst98 mentioned this pull request Jul 26, 2023

[SYCL][Bindless] Fix compiler Werrors #10574

Merged

aelovikov-intel pushed a commit that referenced this pull request Jul 26, 2023

[SYCL][Bindless] Fix compiler Werrors (#10574)

9b93d96

Fix compiler error/warnings related to unused variables/parameters Post-commit fix for PR: #10454 Co-authored-by: Przemek Malon <przemek.malon@codeplay.com>

Seanst98 deleted the codeplay/bindless_images_sycl branch January 31, 2024 12:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SYCL][Bindless][3/4] Add experimental implementation of SYCL bindless images extension #10454

[SYCL][Bindless][3/4] Add experimental implementation of SYCL bindless images extension #10454

Uh oh!

przemektmalon commented Jul 18, 2023

Uh oh!

przemektmalon commented Jul 18, 2023

Uh oh!

EwanC left a comment

Uh oh!

jbrodman commented Jul 19, 2023

Uh oh!

jbrodman commented Jul 24, 2023

Uh oh!

steffenlarsen commented Jul 24, 2023

Uh oh!

AlexeySachkov left a comment

Uh oh!

maarquitos14 left a comment

Uh oh!

Seanst98 commented Jul 25, 2023

Uh oh!

dm-vodopyanov commented Jul 25, 2023

Uh oh!

Seanst98 commented Jul 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

[SYCL][Bindless][3/4] Add experimental implementation of SYCL bindless images extension #10454

[SYCL][Bindless][3/4] Add experimental implementation of SYCL bindless images extension #10454

Uh oh!

Conversation

przemektmalon commented Jul 18, 2023

Overview

Following Split PRs

Authors

Uh oh!

przemektmalon commented Jul 18, 2023

Uh oh!

EwanC left a comment

Choose a reason for hiding this comment

Uh oh!

jbrodman commented Jul 19, 2023

Uh oh!

jbrodman commented Jul 24, 2023

Uh oh!

steffenlarsen commented Jul 24, 2023

Uh oh!

AlexeySachkov left a comment

Choose a reason for hiding this comment

Uh oh!

maarquitos14 left a comment

Choose a reason for hiding this comment

Uh oh!

Seanst98 commented Jul 25, 2023

Uh oh!

dm-vodopyanov commented Jul 25, 2023

Uh oh!

Seanst98 commented Jul 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants