Skip to content

Conversation

@hdelan
Copy link
Contributor

@hdelan hdelan commented Aug 22, 2023

#10691 missed these extra cases. This PR adds the needed ifdefs

@hdelan hdelan requested a review from a team as a code owner August 22, 2023 07:50
@hdelan hdelan requested a review from npmiller August 22, 2023 07:50
@hdelan
Copy link
Contributor Author

hdelan commented Aug 22, 2023

Ping @intel/llvm-gatekeepers this can be merged

@hdelan hdelan closed this Aug 22, 2023
@hdelan hdelan reopened this Aug 22, 2023
@hdelan
Copy link
Contributor Author

hdelan commented Aug 24, 2023

Ping @intel/llvm-gatekeepers can we merge this please?

@dm-vodopyanov
Copy link
Contributor

Ping @intel/llvm-gatekeepers can we merge this please?

Not yet:

image

@hdelan please get the approval from the remaining group, it was recently added to the codeowners file.

@hdelan hdelan requested a review from a team August 24, 2023 12:09
@hdelan
Copy link
Contributor Author

hdelan commented Aug 24, 2023

Aha I didn't realise. Thanks @dm-vodopyanov

@dm-vodopyanov
Copy link
Contributor

@intel/bindless-images-reviewers friendly ping

@hdelan
Copy link
Contributor Author

hdelan commented Aug 30, 2023

Thanks @ProGTX . @dm-vodopyanov this can be merged now. Thanks for patience

@bader bader merged commit 242cb59 into intel:sycl Aug 30, 2023
fabiomestre pushed a commit to fabiomestre/llvm that referenced this pull request Sep 26, 2023
intel#10691 missed these extra cases. This
PR adds the needed ifdefs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants