[SYCL][UR] Implement usm memory pool for hip adapter. #11065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martygrant
force-pushed
the
martin/implementHipUSMPool
branch
2 times, most recently
from
6dca98c to
d32aa83
Compare
jchlanda
reviewed
Sep 6, 2023
jandres742
approved these changes
Sep 7, 2023
jchlanda
approved these changes
Sep 7, 2023
keryell
reviewed
Sep 8, 2023
Contributor
keryell
left a comment
keryell
left a comment
There was a problem hiding this comment.
I have the impression that there is a lot of opportunity to factorize code between CUDA and HIP implementation, for example by using some C++ mixins.
But obviously outside of the scope of this PR.
Update sycl/plugins/unified_runtime/ur/adapters/hip/usm.cpp Co-authored-by: Ronan Keryell <ronan@keryell.fr>
martygrant
force-pushed
the
martin/implementHipUSMPool
branch
from
ee82e77 to
883ab70
Compare
Contributor
|
Failure in post-commit: @martygrant, could you please fix as soon as possible? Please add a link to the PR with the fix here. |
Contributor
Author
|
@dm-vodopyanov apologies for that, fix is in #11154 |
veselypeta
pushed a commit
to veselypeta/llvm
that referenced
this pull request
Sep 28, 2023
Based on intel#10758 Co-authored-by: Ronan Keryell <ronan@keryell.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #10758