[SYCL][LIBCLC] Remove target features attributes when compiling for AMD

[jchlanda]

AMDGPU remove incompatible functions pass replaces all uses of functions that use GPU features incompatible with the current GPU with null then deletes the function. This didn't use to cause problems, as all of libclc functions were inlined prior to incompatible functions pass. Now that the inliner runs later in the pipeline we have to remove all of the target features, so libclc functions will not be earmarked for deletion.

NOTE: I've also reverted the pulldown revert commit to make sure that the original error condition is recreated, hence this PR should not be squashed prior to merging.

Fixes: #10816

[jchlanda]

cc: @jsji

[maksimsab]

Is it just a cherry-pick of https://reviews.llvm.org/D155987 ?

[jchlanda]

Is it just a cherry-pick of https://reviews.llvm.org/D155987 ?

No, the commit you posted got reverted - as it uncovered a bug in libclc - so that the pull down could be finished. See: https://github.com/search?q=repo%3Aintel%2Fllvm+Move+placement+of+RemoveIncompatibleFunctions&type=commits

In this patch I provide the fix for libclc: 5d80ab2dcc16acc458d8b26dcc2b77a93e05195d
And revert the revert: 3f6b08bdaf70fcd4ef4ed04c805f8565f04cec6f

[jchlanda]

Friendly ping @intel/llvm-reviewers-runtime / @intel/llvm-reviewers-cuda, are you happy with the fix and reverting the revert commit?

[asudarsa]

Approving pipeline changes from DPC++ Tools perspective.

Thanks

[jchlanda]

@intel/llvm-gatekeepers this should be ready to go, I'm not sure how to best handle the revert commit, let me know if you'd like me to submit it in a separate PR and drop it from this one, as squashing both of the commits would not make sense here.

[ldrumm]

Sorry/ Missed the notification for this one!

Looks good.

RE: squashing: Yes, your commits should be separate. Hopefully a maintainer can do this without the rigmarole of creating multiple PRs that go in at different times.

[aelovikov-intel]

Hopefully a maintainer can do this without the rigmarole of creating multiple PRs that go in at different times.

Nope, please create two PRs.

[aelovikov-intel]

Request changes to avoid accidental merge without splitting into two PRs.

[jchlanda]

Request changes to avoid accidental merge without splitting into two PRs.

I've dropped the revert commit from this PR (had to rebase/foce push) and opened a new PR with just the revert here: #11438

Thanks for the help.