[SYCL][KernelFusion] Prevent unnecessary scheduler creation #11294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test is a scheduler instance is alive before before attempting to cleanup fusion commands. Signed-off-by: Victor Lomuller <victor@codeplay.com>
Naghasan
force-pushed
the
prevent-scheduler-creation-during-shutdown
branch
from
3cf74af to
bfccda2
Compare
Naghasan
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Author
|
@jsji kindly tested it locally and couldn't observe the issue. So undrafting this PR. |
Naghasan
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
approved these changes
Sep 25, 2023
Contributor
cperkinsintel
left a comment
cperkinsintel
left a comment
There was a problem hiding this comment.
LGTM
I checked this PR on Gen9 and it is fixing the failure we see over there.
The HIP failures on this PR are due to a missing device and most like unrelated.
Author
|
Yes, looks unrelated, the KF support isn't merged yet. |
Author
|
@intel/llvm-gatekeepers the patch looks ready to land. thanks |
Contributor
No, it's not. The AMD runner is broken and the first person who sees it has to notify @intel/dpcpp-devops-reviewers immediately to get it fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test is a scheduler instance is alive before before attempting to cleanup fusion commands.
Hopefully addresses #10948 (comment) (I cannot locally reproduce the issue)