Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release SYCL_INTEL_enqueue_barrier extension document #1199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release SYCL_INTEL_enqueue_barrier extension document #1199
Changes from all commits
0648ad1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if the
submit_barrier
version that takes avector_class<event>
receives an empty list? does it act like thesubmit_barrier
with no parameters, waiting for all submitted command groups to complete, or there is no wait at all? In that case, the event returned is immediately completed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is described below in 4.8.X table:
If
waitList
is empty, then the barrier has no effect.Yes, the event returned is immediately completed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the behavior is fully defined on this. @Ruyk If you disagree or want the material duplicated in this overview section, please comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can any of these methods throw any exception? e.g. should it throw an exception if the waitList is empty? is there any known condition where the barrier will fail to execute? If that is the case, is that a synchronous exception or asynchronous (via callback?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have strong opinion. Any comments? @mkinsner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there should be an exception on empty
waitList
because there are good use cases for a dynamic list that we want to enable, and the list can happen to be empty.I suppose that there could be error conditions if an event in
waitList
is invalid, but SYCL generally doesn't define these sorts of error conditions. So in short, I'm not aware of any condition that we should define which would throw an exception from this API, and therefore I'd choose to not say anything about them in this version of the extension.