Skip to content

[SYCL] Remove fabs and ceil from the list of unsupported math functions #1217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2020
Merged

[SYCL] Remove fabs and ceil from the list of unsupported math functions #1217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions clang/lib/Sema/SemaSYCL.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,12 +138,8 @@ static bool IsSyclMathFunc(unsigned BuiltinID) {
case Builtin::BI__builtin_truncl:
case Builtin::BIlroundl:
case Builtin::BI__builtin_lroundl:
case Builtin::BIceil:
case Builtin::BI__builtin_ceil:
case Builtin::BIcopysign:
case Builtin::BI__builtin_copysign:
case Builtin::BIfabs:
case Builtin::BI__builtin_fabs:
case Builtin::BIfloor:
case Builtin::BI__builtin_floor:
case Builtin::BIfmax:
Expand All @@ -158,12 +154,8 @@ static bool IsSyclMathFunc(unsigned BuiltinID) {
case Builtin::BI__builtin_round:
case Builtin::BItrunc:
case Builtin::BI__builtin_trunc:
case Builtin::BIceilf:
case Builtin::BI__builtin_ceilf:
case Builtin::BIcopysignf:
case Builtin::BI__builtin_copysignf:
case Builtin::BIfabsf:
case Builtin::BI__builtin_fabsf:
case Builtin::BIfloorf:
case Builtin::BI__builtin_floorf:
case Builtin::BIfmaxf:
Expand Down
12 changes: 0 additions & 12 deletions clang/test/SemaSYCL/unsupported_math.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,9 @@
extern "C" float sinf(float);
extern "C" float cosf(float);
extern "C" float logf(float);
extern "C" float ceilf(float);
extern "C" float fabsf(float);
extern "C" double sin(double);
extern "C" double cos(double);
extern "C" double log(double);
extern "C" double ceil(double);
extern "C" double fabs(double);
template <typename name, typename Func>
__attribute__((sycl_kernel)) void kernel(Func kernelFunc) {
kernelFunc();
Expand All @@ -30,14 +26,6 @@ int main() {
acc[0] += (int)log(1.0); // expected-no-error
acc[0] += (int)__builtin_logf(1.0f); // expected-no-error
acc[0] += (int)__builtin_log(1.0); // expected-no-error
acc[0] += (int)ceilf(1.0f); // expected-error{{builtin is not supported on this target}}
acc[0] += (int)ceil(1.0); // expected-error{{builtin is not supported on this target}}
acc[0] += (int)__builtin_ceilf(1.0f); // expected-error{{builtin is not supported on this target}}
acc[0] += (int)__builtin_ceil(1.0); // expected-error{{builtin is not supported on this target}}
acc[0] += (int)fabsf(-1.0f); // expected-error{{builtin is not supported on this target}}
acc[0] += (int)fabs(-1.0); // expected-error{{builtin is not supported on this target}}
acc[0] += (int)__builtin_fabsf(-1.0f); // expected-error{{builtin is not supported on this target}}
acc[0] += (int)__builtin_fabs(-1.0); // expected-error{{builtin is not supported on this target}}
acc[0] += (int)__builtin_fabsl(-1.0); // expected-error{{builtin is not supported on this target}}
acc[0] += (int)__builtin_cosl(-1.0); // expected-error{{builtin is not supported on this target}}
acc[0] += (int)__builtin_powl(-1.0, 10.0); // expected-error{{builtin is not supported on this target}}
Expand Down