Fix hip memadvise events regression #12333
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeWeb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
GeorgeWeb
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Contributor
|
Could you please add a comment to the test explaining why -996 is an acceptable result? |
GeorgeWeb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
Yeah I've just added it. It's used as a warning in mem advise similarly to how it was previously used in the prefetch implementation for CUDA. |
GeorgeWeb
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Contributor
Author
|
Closing as I will be moving those test changes to the relevant PR #10697. I confused myself thinking it was already merged (what was actually merged was its unified-runtime dependency), hence I created this PR to fix the regression. First day after holidays haha. Thanks for the review though @sergey-semenov! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the event discarding lit tests that check the
piextUSMEnqueueMemAdviseentry point. The return code can also bePI_ERROR_PLUGIN_SPECIFIC_ERROR(-996) if the driver returns that managed memory is not supported for the device.