[SYCL][E2E] Refactor Basic/built-ins/marray_common.cpp #12875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
added a commit
that referenced
this pull request
Mar 1, 2024
This reverts commit 5ec9cce.
aelovikov-intel
added a commit
that referenced
this pull request
Mar 1, 2024
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 18, 2024
Second attempt, first was in intel#12875.
aelovikov-intel
added a commit
that referenced
this pull request
Mar 20, 2024
…12877) Unfortunately, can't do the same for `sycl::vec` tests because swizzles can't be captured and a macro seems unavoidable. Also, this includes a reworked version of #12875 that has been reverted in #12887. That also uncovered a bug in our `sycl::length` host implementation when the project is compiled using GCC. I'm not sure if that's a GCC bug or yet another instance of UB in `sycl::vec`/`sycl::half` implementation, but the only option at the moment is to workaround, which I'm doing here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.