[NFCI] Introduce <sycl/detail/core.hpp> include#12890
[NFCI] Introduce <sycl/detail/core.hpp> include#12890aelovikov-intel merged 4 commits intointel:syclfrom
Conversation
|
Could you run something like: and compare sycl.deps vs core.deps? From my experiments in the past, I noticed that just queue.hpp implicitly includes ~70% of SYCL headers. I would really want to document core.hpp as oneAPI, extension so it can be used by the users (not just tests). |
234f07a to
90bbe9a
Compare
|
AlexeySachkov
left a comment
There was a problem hiding this comment.
Whilst I support activities to speed up our tests (see my previous attempts in #7438), I have a concern about modifying E2E tests: they now can't be used as examples of SYCL usage, because they all contain non-standard undocumented functionality which can easily confuse our users.
I don't see any documentation being updated:
- it will be a bit harder (i.e. less obvious) for someone who haven't seen the patch to figure out what's going on
- we will have to explain this separately to everyone who is asking questions
- new tests will still be added with
sycl/sycl.hppunless someone thoroughly reviews all patches
I'm afraid this is a chicken and an egg problem. We can't make a meaningful documentation update (e.g. an official extension) until we've experimented enough and found out what we can reasonably achieve. On the other hand, I doubt anybody could work on this full-time and not being able to commit small incremental pieces would result in most of the time spent in rebases/merges slowing down any possible progress even further. I personally expect myself working on this not more than a few hours a week. I think the best we can have at the time is an informal discussion/direction alignment (like comments in this PR) and then anybody could keep making minor contribution until we have a better understanding of what works and what not. As a result, I think
is completely ok for the time being. Also, we already have some tests that only include individual headers and not the entire |
cperkinsintel
left a comment
There was a problem hiding this comment.
I think this is great and should have been done from the beginning.
But I do think we should document it, even if just as an experimental extension. If it's useful to us, it's likely to be useful to other users.
The idea is to have a thinner version of `<sycl/sycl.hpp>` that allows to run basic tests and enables fine-grained includes in our e2e tests. Hopefully that can increase CI efficiency.
90bbe9a to
c739683
Compare
|
@intel/syclcompat-lib-reviewers , @intel/dpcpp-esimd-reviewers , ping. |
sarnex
left a comment
There was a problem hiding this comment.
No additional flags from ESIMD
…ore/*` Continuation of changes started in intel#12890.
Continuation of changes started in intel#12890.
Continuation of changes started in intel#12890.
Continuation of changes started in #12890.
The idea is to have a thinner version of
<sycl/sycl.hpp>that allows to run basic tests and enables fine-grained includes in our e2e tests. Hopefully that can increase CI efficiency.