Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Fix some typos #13

Merged
merged 1 commit into from
Jan 31, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clang/include/clang/Basic/DiagnosticDriverKinds.td
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ def warn_drv_omp_offload_target_duplicate : Warning<
"The OpenMP offloading target '%0' is similar to target '%1' already specified - will be ignored.">,
InGroup<OpenMPTarget>;
def warn_drv_sycl_offload_target_duplicate : Warning<
"The SYCL offloading target '%0' is similar to target '%1' already specified - will be ignored.">,
"The SYCL offloading target '%0' is similar to target '%1' already specified - will be ignored.">,
InGroup<SyclTarget>;
def warn_drv_omp_offload_target_missingbcruntime : Warning<
"No library '%0' found in the default clang lib directory or in LIBRARY_PATH. Expect degraded performance due to no inlining of runtime functions on target devices.">,
Expand Down
2 changes: 1 addition & 1 deletion clang/include/clang/Driver/ToolChain.h
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ class ToolChain {
}

/// TranslateOffloadTargetArgs - Create a new derived argument list for
/// that contains the Offloat target specific flags passed via
/// that contains the Offload target specific flags passed via
/// -Xopenmp-target -opt=val OR -Xopenmp-target=<triple> -opt=val
/// Also handles -Xsycl-target OR -Xsycl-target=<triple>
virtual llvm::opt::DerivedArgList *TranslateOffloadTargetArgs(
Expand Down
6 changes: 3 additions & 3 deletions clang/include/clang/Sema/Sema.h
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ class FileNullabilityMap {
// mechanism should be developed to enforce that.

// TODO FIXME SYCL Support for SYCL in FE should be refactored:
// - kernel indentification and generation should be made a separate pass over
// - kernel identification and generation should be made a separate pass over
// AST. RecursiveASTVisitor + VisitFunctionTemplateDecl +
// FunctionTemplateDecl::getSpecializations() mechanism could be used for that.
// - All SYCL stuff on Sema level should be encapsulated into a single Sema
Expand Down Expand Up @@ -10957,15 +10957,15 @@ class Sema {
// We store SYCL Kernels here and handle separately -- which is a hack.
// FIXME: It would be best to refactor this.
SmallVector<Decl*, 4> SyclKernel;
// SYCL integratrion header instance for current compilation unit this Sema
// SYCL integration header instance for current compilation unit this Sema
// is associated with.
std::unique_ptr<SYCLIntegrationHeader> SyclIntHeader;

public:
void AddSyclKernel(Decl * d) { SyclKernel.push_back(d); }
SmallVector<Decl*, 4> &SyclKernels() { return SyclKernel; }

/// Lazily creates and returns SYCL integratrion header instance.
/// Lazily creates and returns SYCL integration header instance.
SYCLIntegrationHeader &getSyclIntegrationHeader() {
if (SyclIntHeader == nullptr)
SyclIntHeader = llvm::make_unique<SYCLIntegrationHeader>(
Expand Down
2 changes: 1 addition & 1 deletion clang/lib/CodeGen/CodeGenTypes.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ void CodeGenTypes::addRecordTypeName(const RecordDecl *RD,
// NOTE: The following block of code is copied from CLANG-3.6 with
// support of OpenCLCPlusPlus. It is rather the temporary solution
// that is going to be used until the general solution is ported/developed
// in the latest llvm trunc.
// in the latest llvm trunk.
//
// For SYCL, the mangled type name is attached, so it can be
// reflown to proper name later.
Expand Down
4 changes: 2 additions & 2 deletions clang/lib/Driver/Driver.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3204,9 +3204,9 @@ class OffloadingActionBuilder final {
for (StringRef Val : SYCLAddTargets->getValues()) {
// Parse out the Triple and Input (triple:binary) and create a
// ToolChain for each entry. Each of these will be wrapped and fed
// into the final binary
// into the final binary.
// Populate the pairs, expects format of 'triple:file', any other
// format will not be accepted
// format will not be accepted.
std::pair<StringRef, StringRef> I = Val.split(':');
llvm::Triple TT;
const char * TF;
Expand Down
2 changes: 1 addition & 1 deletion clang/lib/Sema/SemaSYCL.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -712,7 +712,7 @@ void Sema::ConstructSYCLKernel(FunctionDecl *KernelCallerFunc) {
const TemplateArgumentList *TemplateArgs =
KernelCallerFunc->getTemplateSpecializationArgs();
assert(TemplateArgs && "No template argument info");
// The first teamplate argument always describes the kernel name - whether
// The first template argument always describes the kernel name - whether
// it is lambda or functor.
QualType KernelNameType = TypeName::getFullyQualifiedType(
TemplateArgs->get(0).getAsType(), getASTContext(), true);
Expand Down
2 changes: 1 addition & 1 deletion llvm/lib/SYCL/ASFixer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -554,7 +554,7 @@ struct ASFixer : public ModulePass {
// into structure so we need to check structures with
// pointers and replace it if needed.
// As described in SYCL spec structures with pointers
// can't be passes as kernel argument so we check
// can't be passed as kernel argument so we check
// allocas of structures with pointers.
std::vector<std::pair<Value *, Value *>> BadAllocas;
TypeToTypeMap TMap;
Expand Down
2 changes: 1 addition & 1 deletion sycl/include/CL/sycl/swizzles.def
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
//
//===----------------------------------------------------------------------===//

// included to types.hppp twice, once for vec<> and once for SwizzleOp<>.
// Included by types.hpp twice, once for vec<> and once for SwizzleOp<>.

// TODO: exclude L-Value swizzle like vec.xxxx()
#ifdef __SYCL_ACCESS
Expand Down
4 changes: 2 additions & 2 deletions sycl/test/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ set(SYCL_TEST_DEPS
FileCheck
${SYCLLibrary}
)
add_lit_testsuite(check-sycl "Running the Sycl regression tests"
add_lit_testsuite(check-sycl "Running the SYCL regression tests"
${CMAKE_CURRENT_BINARY_DIR}
ARGS ${RT_TEST_ARGS}
DEPENDS ${SYCL_TEST_DEPS}
)
set_target_properties(check-sycl PROPERTIES FOLDER "Sycl tests")
set_target_properties(check-sycl PROPERTIES FOLDER "SYCL tests")