[SYCL] Setup deprecation warnings for device info descriptors that have been deprecated and not part SYCL 2020 #13279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
…size and info::device::image_max_array_size Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
HPS-1
changed the title
Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
gmlueck
approved these changes
Apr 10, 2024
steffenlarsen
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the CTS pull request KhronosGroup/SYCL-CTS#870, two device info descriptors, namely
info::device::image_max_array_sizeandinfo::device::opencl_c_version, have been deprecated and no longer exist in the SYCL 2020 specification. But they still exist in our implementation, so I'm setting up deprecation warnings for them. Also a related test case has been revised to remove the usage ofinfo::device::opencl_c_version.Also
info::device::usm_system_allocatorhas been replaced and marked as deprecated 2+ years ago in PR #4007 and #9217 respectively. So I'm cleaning up a few relevant code pieces in our code as well in this PR.