-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][Matrix] Switch to SPV_KHR_cooperative_matrix extension #13316
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrSidims
force-pushed
the
switch-to-coop-matrix
branch
from
April 8, 2024 10:58
020dd9e
to
fbbd986
Compare
MrSidims
commented
Apr 8, 2024
MrSidims
force-pushed
the
switch-to-coop-matrix
branch
from
April 8, 2024 11:13
fbbd986
to
30c140b
Compare
Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
MrSidims
force-pushed
the
switch-to-coop-matrix
branch
from
April 8, 2024 11:29
30c140b
to
5b8e9eb
Compare
Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
MrSidims
commented
Apr 23, 2024
@@ -6506,6 +6506,48 @@ LLVMToSPIRVBase::transBuiltinToInstWithoutDecoration(Op OC, CallInst *CI, | |||
transValue(CI->getArgOperand(1), BB), MemoryAccess, | |||
BB); | |||
} | |||
/* case OpAccessChain: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to remove
MrSidims
added a commit
to MrSidims/llvm
that referenced
this pull request
May 17, 2024
…el's The usage is currently guarded by __SPIRV_USE_COOPERATIVE_MATRIX macro. It's a split from intel#13316 Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.