Skip to content

Conversation

@Alcpz
Copy link

@Alcpz Alcpz commented Apr 15, 2024

This PR replaces #11340

This PR extends the memory header to include 2 byte and 4 byte memsets.

  • memset remains unchanged.
    • 2D / 3D memsets are templated and wrap sycl::fill. Functionality remains unchanged as it is exposed through detail::memset<unsigned char>, equivalent to what we had before.
  • memset_d16 and memset_d32 calls are added wrapped around sycl::fill using 2-byte and 4-byte datatypes

Added tests for memset_d16 and memset_d32.

@Alcpz
Copy link
Author

Alcpz commented Apr 16, 2024

@intel/llvm-gatekeepers This is ready for merging Thanks!

CUDA backend failure unrelated. Issue already reported.

@sommerlukas sommerlukas merged commit a5a0e12 into intel:sycl Apr 16, 2024
@Alcpz Alcpz deleted the Alcpz/memory-update-2 branch June 3, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants