Skip to content

Conversation

@jsji
Copy link
Contributor

@jsji jsji commented Apr 22, 2024

Allow to use default igc with label so that we may ignore regressions in
igc dev when needed.

@jsji jsji closed this Apr 23, 2024
@jsji jsji reopened this Apr 23, 2024
@jsji jsji added the ci-no-devigc Do NOT use IGC dev driver in CI for Matrix e2e tests label Apr 23, 2024
@jsji jsji closed this Apr 23, 2024
@jsji jsji reopened this Apr 23, 2024
@jsji jsji removed the ci-no-devigc Do NOT use IGC dev driver in CI for Matrix e2e tests label Apr 23, 2024
@jsji jsji closed this Apr 23, 2024
@jsji jsji reopened this Apr 23, 2024
@jsji jsji temporarily deployed to WindowsCILock April 25, 2024 14:00 — with GitHub Actions Inactive
@jsji jsji temporarily deployed to WindowsCILock April 25, 2024 14:36 — with GitHub Actions Inactive
@jsji jsji self-assigned this Apr 29, 2024
Allow to use default igc with label so that we may ignore regressions in
igc dev when needed.
@jsji jsji force-pushed the jointmatrixigcdev branch from 5d07bcf to 2e3a6a0 Compare May 3, 2024 14:47
@jsji jsji changed the title [CI] Run Matrix E2E tests with igc-dev by default [CI] Run E2E tests on Arc with igc-dev by default May 3, 2024
@jsji jsji changed the title [CI] Run E2E tests on Arc with igc-dev by default [CI] Run Pre-commit E2E tests on Arc with igc-dev by default May 3, 2024
@jsji jsji requested review from YuriPlyakhin and sarnex May 3, 2024 19:16
@jsji jsji marked this pull request as ready for review May 3, 2024 19:16
@jsji jsji requested a review from a team as a code owner May 3, 2024 19:16
Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm to be but probably @aelovikov-intel should review in-depth :)

use_dev_igc: ${{ contains(needs.detect_changes.outputs.filters, 'devigccfg') }}
extra_lit_opts: --param matrix-xmx8=True --param gpu-intel-dg2=True
env: '{"LIT_FILTER":${{ needs.determine_arc_tests.outputs.arc_tests }} }'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove newline

@aelovikov-intel aelovikov-intel merged commit c7e4670 into sycl May 3, 2024
@aelovikov-intel aelovikov-intel deleted the jointmatrixigcdev branch May 3, 2024 19:34
@jsji
Copy link
Contributor Author

jsji commented May 3, 2024

Thanks @sarnex @aelovikov-intel !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants