[SYCL] Fix WA for ocl query of CL_DEVICE_PROFILE #13584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| // Fails with opencl and level_zero on linux, enable when fixed. | ||
| // XFAIL: opencl || (linux && level_zero) | ||
| // Fails with level_zero on linux, enable when fixed. | ||
| // XFAIL: (linux && level_zero) |
Contributor
There was a problem hiding this comment.
Pretty sure this can be removed. It was added when the driver change triggered new failures ( #13547 )
Your new WA should mean that the test should pass everywhere.
Contributor
Author
There was a problem hiding this comment.
@cperkinsintel do we want to proceed with this WA update? it will hide the problem with opencl reporting, not solve it
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
approved these changes
Apr 30, 2024
Contributor
Author
|
@intel/llvm-gatekeepers hi, this PR is ready for merge. Thanks |
Contributor
|
Please make future developers' lives easier by providing a useful commit message. As it is, I have no idea of the history or intent of this patch |
KseniyaTikhomirova
changed the title
Contributor
Author
done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves kernel_compiler WA for CL_DEVICE_PROFILE query.
Currently ocl query returns some extra symbols we want to eliminate from final result returned to user.
Removes all special symbols now. To be removed once ocl query is fixed.