Skip to content

stop batching multiple CmdList execution when waiting for barriers#13599

Closed
pbalcer wants to merge 6 commits intointel:syclfrom
pbalcer:fix-enqueue-wait-barrier
Closed

stop batching multiple CmdList execution when waiting for barriers#13599
pbalcer wants to merge 6 commits intointel:syclfrom
pbalcer:fix-enqueue-wait-barrier

Conversation

@pbalcer
Copy link
Contributor

@pbalcer pbalcer commented Apr 30, 2024

No description provided.

@kbenzie kbenzie temporarily deployed to WindowsCILock May 3, 2024 09:29 — with GitHub Actions Inactive
@kbenzie kbenzie temporarily deployed to WindowsCILock May 3, 2024 09:52 — with GitHub Actions Inactive
@kbenzie kbenzie temporarily deployed to WindowsCILock May 3, 2024 11:05 — with GitHub Actions Inactive
@kbenzie kbenzie temporarily deployed to WindowsCILock May 3, 2024 13:09 — with GitHub Actions Inactive
@kbenzie kbenzie temporarily deployed to WindowsCILock May 3, 2024 13:22 — with GitHub Actions Inactive
@kbenzie kbenzie marked this pull request as draft May 3, 2024 14:12
@kbenzie kbenzie temporarily deployed to WindowsCILock May 3, 2024 14:13 — with GitHub Actions Inactive
@kbenzie kbenzie temporarily deployed to WindowsCILock May 3, 2024 14:36 — with GitHub Actions Inactive
@kbenzie
Copy link
Contributor

kbenzie commented May 3, 2024

Looks like the UR change is causing a few regressions (GEN12 Linux, GEN12 Windows):

 ********************
Failed Tests (3):
  SYCL :: Basic/barrier_order.cpp
  SYCL :: Plugin/level_zero_batch_barrier.cpp
  SYCL :: Regression/barrier_with_work.cpp

I'm going to revert the UR change. I've already marked this as draft.

As far as I can tell these don't always fail since I did get a clean run, which is why I merged the UR change to main in the first place.

@pbalcer
Copy link
Contributor Author

pbalcer commented May 6, 2024

Yea, I was afraid that something like this might happen. This might require a bigger change than I expected. Let's close this for now and I'll create another PR with a revised fix.

@pbalcer pbalcer closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments