[SYCL] Fix bug in sampler implementation #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanovvlad
approved these changes
May 14, 2019
romanovvlad
previously approved these changes
May 15, 2019
Contributor
|
@Fznamznon, please, rebase the patch to the tip of the branch. |
Fznamznon
force-pushed
the
private/mpodchis/fixsampler
branch
from
5105964 to
d623eab
Compare
Contributor
Author
Done |
bader
previously approved these changes
May 17, 2019
Contributor
Author
|
Looks like test failures are caused not by my change. Will we commit this patch in this case? |
Contributor
|
Our development process do not allow merging PRs with failing tests. We must fix all the failures before we can continue merging patches. |
When sampler was created on host with enums and passed to device we released null sampler because in GetOrCreateSampler we set m_ReleaseSampler to true and stored created sampler not into m_Sampler field which is released in destructor. Signed-off-by: Mariya Podchishchaeva <mariya.podchishchaeva@intel.com>
Contributor
|
@Fznamznon, the regression was fixed. Please, rebase your patch one more time. |
Fznamznon
force-pushed
the
private/mpodchis/fixsampler
branch
from
d623eab to
135b087
Compare
bader
approved these changes
May 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sampler was created on host with enums and passed to device we
released null sampler because in GetOrCreateSampler we set m_ReleaseSampler to
true and stored created sampler not into m_Sampler field which is released in
destructor.
Signed-off-by: Mariya Podchishchaeva mariya.podchishchaeva@intel.com