Skip to content

[SYCL][Doc] Extension spec for "work_group_memory" #13725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 7, 2024

Conversation

gmlueck
Copy link
Contributor

@gmlueck gmlueck commented May 9, 2024

Add a proposed extension specification for work_group_memory, a
lighter weight API to allocate device local memory for an nd-range
kernel.

Also related, add a list of restrictions that, when followed, provide a
guarantee that a kernel written in the free-function kernel syntax can
be launched directly via Level Zero or OpenCL.

gmlueck added 2 commits May 8, 2024 16:57
Add a proposed extension specification for `work_group_memory`, a
lighter weight API to allocate device local memory for an nd-range
kernel.
Add a list of restrictions that, when followed, provide a guarantee
that a kernel written in the free-function kernel syntax can be
launched directly via Level Zero or OpenCL.
@gmlueck gmlueck requested a review from a team as a code owner May 9, 2024 14:04
gmlueck added 2 commits May 17, 2024 13:52
Add example using `work_group_memory` in free function kernel.
@gmlueck
Copy link
Contributor Author

gmlueck commented Jun 6, 2024

Ping @intel/dpcpp-specification-reviewers: Could someone review this please?

gmlueck added 2 commits June 7, 2024 07:49
The core SYCL spec requires an `errc::kernel_argument` exception
if a `local_memory` object is passed to a single-task or simple "range"
kernel.  Add the same requirement for `work_group_memory`.
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlueck
Copy link
Contributor Author

gmlueck commented Jun 7, 2024

@intel/llvm-gatekeepers I think this is ready to merge.

@aelovikov-intel aelovikov-intel merged commit 25bfb0b into intel:sycl Jun 7, 2024
3 checks passed
@gmlueck gmlueck deleted the gmlueck/work-group-memory branch June 7, 2024 20:19
ianayl pushed a commit to ianayl/sycl that referenced this pull request Jun 13, 2024
Add a proposed extension specification for `work_group_memory`, a
lighter weight API to allocate device local memory for an nd-range
kernel.

Also related, add a list of restrictions that, when followed, provide a
guarantee that a kernel written in the free-function kernel syntax can
be launched directly via Level Zero or OpenCL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants