-
Notifications
You must be signed in to change notification settings - Fork 765
[SYCL][Doc] Extension spec for "work_group_memory" #13725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a proposed extension specification for `work_group_memory`, a lighter weight API to allocate device local memory for an nd-range kernel.
Add a list of restrictions that, when followed, provide a guarantee that a kernel written in the free-function kernel syntax can be launched directly via Level Zero or OpenCL.
bsochack
reviewed
May 13, 2024
sycl/doc/extensions/proposed/sycl_ext_oneapi_free_function_kernels.asciidoc
Outdated
Show resolved
Hide resolved
Add example using `work_group_memory` in free function kernel.
Ping @intel/dpcpp-specification-reviewers: Could someone review this please? |
sycl/doc/extensions/proposed/sycl_ext_oneapi_work_group_memory.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/proposed/sycl_ext_oneapi_work_group_memory.asciidoc
Outdated
Show resolved
Hide resolved
The core SYCL spec requires an `errc::kernel_argument` exception if a `local_memory` object is passed to a single-task or simple "range" kernel. Add the same requirement for `work_group_memory`.
steffenlarsen
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@intel/llvm-gatekeepers I think this is ready to merge. |
ianayl
pushed a commit
to ianayl/sycl
that referenced
this pull request
Jun 13, 2024
Add a proposed extension specification for `work_group_memory`, a lighter weight API to allocate device local memory for an nd-range kernel. Also related, add a list of restrictions that, when followed, provide a guarantee that a kernel written in the free-function kernel syntax can be launched directly via Level Zero or OpenCL.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a proposed extension specification for
work_group_memory
, alighter weight API to allocate device local memory for an nd-range
kernel.
Also related, add a list of restrictions that, when followed, provide a
guarantee that a kernel written in the free-function kernel syntax can
be launched directly via Level Zero or OpenCL.