[Bindless][SYCL][Doc] Add HintT tparam to cubemap fetch and sample #13742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add HintT template parameter to the fetch_cubemap and sample_cubemap funcs in the bindless spec. Add HintT template parameter and doxygen to the fetch_cubemap and sample_cubemap implementation. Modify existing cubemap_sampled.cpp test to test the sampling with a user-defined type.
DBDuncan
approved these changes
May 10, 2024
isaacault
approved these changes
May 10, 2024
cppchedy
approved these changes
May 10, 2024
Contributor
Author
|
@intel/llvm-gatekeepers can we merge this please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add HintT template parameter to the fetch_cubemap and sample_cubemap funcs in the bindless spec.
Add HintT template parameter and doxygen to the fetch_cubemap and sample_cubemap implementation.
Modify existing cubemap_sampled.cpp test to test the sampling with a user-defined type.